Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VirusTotal] Add custom fields to indicators #35448

Merged

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@pabloperezj

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

* Add custom fields

* nit

* Lint

* Update docker image

* Update readme and release notes

* Update fields

* Update release note

* Update all indicators

* Update version

* Restore unused fields

* Update Packs/VirusTotal/IndicatorFields/indicatorfield-VT_Engine_Detection_Names.json

Co-authored-by: Sasha Sokolovich <88268646+ssokolovich@users.noreply.github.com>

* Update Packs/VirusTotal/IndicatorFields/indicatorfield-VT_Engine_Detections.json

Co-authored-by: Sasha Sokolovich <88268646+ssokolovich@users.noreply.github.com>

* Update Packs/VirusTotal/IndicatorFields/indicatorfield-VT_Engine_Vendors.json

Co-authored-by: Sasha Sokolovich <88268646+ssokolovich@users.noreply.github.com>

* Update Packs/VirusTotal/Integrations/VirusTotalV3/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/VirusTotal/Integrations/VirusTotalV3/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/VirusTotal/Integrations/VirusTotalV3/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/VirusTotal/Integrations/VirusTotalV3/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/VirusTotal/Integrations/VirusTotalV3/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/VirusTotal/Integrations/VirusTotalV3/VirusTotalV3.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/VirusTotal/Integrations/VirusTotalV3/VirusTotalV3.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/VirusTotal/Integrations/VirusTotalV3/VirusTotalV3.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/VirusTotal/ReleaseNotes/2_6_21.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/VirusTotal/ReleaseNotes/2_6_22.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/VirusTotal/Integrations/VirusTotalV3/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/VirusTotal/Integrations/VirusTotalV3/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/VirusTotal/Integrations/VirusTotalV3/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/VirusTotal/Integrations/VirusTotalV3/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/VirusTotal/Integrations/VirusTotalV3/VirusTotalV3.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

---------

Co-authored-by: Sasha Sokolovich <88268646+ssokolovich@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved Partner Contribution Form Filled Whether contribution form filled or not. Partner Support Level Indicates that the contribution is for Partner supported pack Internal PR Security Review Partner-Approved TIM Review labels Jul 16, 2024
Copy link

github-actions bot commented Jul 16, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/VirusTotal/Integrations/VirusTotalV3
   VirusTotalV3.py103551450%110, 115–117, 120–121, 123, 125–126, 128–129, 131–132, 134–135, 137, 163–164, 166, 168–169, 171–172, 174–175, 177–178, 180, 206–207, 209, 211–212, 214–215, 217–218, 220–221, 223, 249–250, 252, 254–255, 257–258, 260–261, 263–264, 266, 308, 352, 364, 376, 387, 398, 409, 424, 435, 442, 449, 456, 466, 477–482, 489, 495, 499, 507–511, 518, 524, 528, 535, 545, 555, 580, 591, 602, 612, 622, 632, 649, 661, 670, 682, 694, 706, 715, 727, 739, 751, 760, 772, 784, 991–994, 996, 998, 1002, 1060, 1082, 1084, 1110, 1114, 1118, 1121, 1123, 1125, 1127, 1129, 1190–1198, 1200–1201, 1203–1205, 1208–1209, 1211, 1233–1248, 1262, 1284, 1306, 1344, 1350, 1399, 1433, 1437, 1445, 1449, 1457, 1461, 1469, 1473, 1481, 1485, 1643–1646, 1648, 1650–1651, 1653–1654, 1661, 1666, 1873–1874, 1876–1878, 1880–1881, 1888, 1890–1891, 1893–1896, 1996–2001, 2061–2063, 2090–2092, 2096, 2098–2101, 2116–2119, 2121–2134, 2136–2144, 2160–2162, 2168, 2170–2173, 2194–2196, 2200, 2202–2205, 2227–2229, 2233, 2235–2238, 2258–2263, 2267, 2281–2284, 2324, 2331, 2338–2348, 2350–2351, 2353, 2356–2360, 2364, 2374–2377, 2382, 2389–2391, 2396, 2410–2414, 2416–2418, 2420–2421, 2425–2426, 2429–2431, 2433, 2435, 2456, 2461–2465, 2467–2474, 2476–2485, 2487, 2489–2490, 2494–2497, 2499–2500, 2502–2504, 2512, 2529–2548, 2550–2554, 2577–2582, 2619–2621, 2645–2646, 2661–2672, 2674, 2676, 2678, 2684–2687, 2689–2690, 2714–2720, 2738–2743, 2767–2771, 2774–2785, 2810–2811, 2816–2818, 2823–2826, 2828–2829, 2831–2832, 2849, 2869–2871, 2873–2876, 2878, 2880–2922, 2924–2925
TOTAL103551450% 

Tests Skipped Failures Errors Time
138 0 💤 0 ❌ 0 🔥 6.403s ⏱️

@thefrieddan1 thefrieddan1 merged commit 134f4b1 into master Jul 16, 2024
16 checks passed
@thefrieddan1 thefrieddan1 deleted the contrib/VirusTotal_virustotal-custom-indicator-fields branch July 16, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved Security Review TIM Review
Projects
None yet
5 participants