Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incident model doesn't match answer from API #50

Closed
smadessis opened this issue Sep 24, 2020 · 1 comment · Fixed by #53
Closed

Incident model doesn't match answer from API #50

smadessis opened this issue Sep 24, 2020 · 1 comment · Fixed by #53

Comments

@smadessis
Copy link

Hi Demisto team,

I'm trying to gather incidents from Cortex XSOAR and perform filtering on it by transforming the object to Python dictionnary.
However, the model of "Incident" doesn't match the answer I get from Cortex XSOAR.
There is no proprety "CustomFields" for the object, while it's present in the answer.

The original API documentation also doesn't seem correct, and only mention this proprety for IocObject while it's also present for Incidents.

IoC object has indeed the proprety CustomFields:
https://github.com/demisto/demisto-py/blob/95ed78223eb89f2079ce222b0d25ef39868dc9fb/demisto_client/demisto_api/models/ioc_object.py

How to reproduce:
[...]
api_response = api_instance.search_incidents(filter=filter)
incidents = api_response.data
print(api_response) #This shows CustomFields field is indeed present, while it doesn't show up in the model

@glicht
Copy link
Collaborator

glicht commented Sep 28, 2020

Thanks for reporting this. We will check regarding adding this to the model.

@glicht glicht mentioned this issue Oct 5, 2020
2 tasks
@glicht glicht closed this as completed in #53 Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants