code review changes

demisto · Jun 2, 2024 · 358bf1f · 358bf1f
1 parent f2b5ca8
commit 358bf1f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/demisto_sdk/commands/validate/sdk_validation_config.toml b/demisto_sdk/commands/validate/sdk_validation_config.toml
@@ -34,6 +34,7 @@ select = [
     "DS100", "DS107",
     "SC100", "SC105", "SC106", "SC109",
     "RM104", "RM105", "RM106", "RM109", "RM113", "RM114",
+    "RN103",
     "CL100",
     "GF100", "GF101", "GF102",
     "IF100", "IF101", "IF102", "IF103", "IF104", "IF105", "IF106", "IF116",

diff --git a/demisto_sdk/commands/validate/tests/RN_validators_test.py b/demisto_sdk/commands/validate/tests/RN_validators_test.py
@@ -35,8 +35,8 @@
                 ),  # shouldn't pass as it has an invalid release note
             ],
             3,
-            ["Please finish filling out the release notes. For common troubleshooting steps, please "
-             "review the documentation found here: "
+            ["Please complete the release notes and ensure all placeholders are filled in."
+             "For common troubleshooting steps, please review the documentation found here: "
              "https://xsoar.pan.dev/docs/integrations/changelog#common-troubleshooting-tips"],
         ),
     ],

diff --git a/demisto_sdk/commands/validate/validators/RN_validators/RN103_is_release_notes_filled_out.py b/demisto_sdk/commands/validate/validators/RN_validators/RN103_is_release_notes_filled_out.py
@@ -17,9 +17,9 @@ class IsReleaseNotesFilledOutValidator(BaseValidator[ContentTypes]):
     error_code = "RN103"
     description = "Validate that the pack contains a full release note file."
     rationale = "Meaningful, complete documentations make it easier for users to use the content."
-    error_message = "Please finish filling out the release notes. For common troubleshooting steps, please "\
-                    "review the documentation found here: "\
-                    "https://xsoar.pan.dev/docs/integrations/changelog#common-troubleshooting-tips"
+    error_message = ("Please complete the release notes and ensure all placeholders are filled in."
+                     "For common troubleshooting steps, please review the documentation found here: "
+                     "https://xsoar.pan.dev/docs/integrations/changelog#common-troubleshooting-tips")
     related_field = "release_note"
     is_auto_fixable = False
     related_file_type = [RelatedFileType.RELEASE_NOTE]