added TODO comments

demisto · Apr 13, 2020 · 677f75f · 677f75f
1 parent 836af9e
commit 677f75f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/demisto_sdk/commands/common/tests/tools_test.py b/demisto_sdk/commands/common/tests/tools_test.py
@@ -67,14 +67,18 @@ def test_find_type(self, path, _type):
 
 class TestGetRemoteFile:
     def test_get_remote_file_sanity(self):
-        gmail_yml = tools.get_remote_file('Integrations/Gmail/Gmail.yml')
-        assert gmail_yml
-        assert gmail_yml['commonfields']['id'] == 'Gmail'
+        hello_world_yml = tools.get_remote_file('Packs/HelloWorld/Integrations/HelloWorld/HelloWorld.yml')
+        assert hello_world_yml
+        assert hello_world_yml['commonfields']['id'] == 'HelloWorld'
 
     def test_get_remote_file_origin(self):
-        gmail_yml = tools.get_remote_file('Integrations/Gmail/Gmail.yml', 'master')
-        assert gmail_yml
-        assert gmail_yml['commonfields']['id'] == 'Gmail'
+        hello_world_yml = tools.get_remote_file('Packs/HelloWorld/Integrations/HelloWorld/HelloWorld.yml', 'master')
+        assert hello_world_yml
+        assert hello_world_yml['commonfields']['id'] == 'HelloWorld'
+
+    def test_get_remote_md_file_origin(self):
+        hello_world_readme = tools.get_remote_file('Packs/HelloWorld/README.md', 'master')
+        assert hello_world_readme == {}
 
     def test_get_remote_file_tag(self):
         gmail_yml = tools.get_remote_file('Integrations/Gmail/Gmail.yml', '19.10.0')

diff --git a/demisto_sdk/commands/common/tools.py b/demisto_sdk/commands/common/tools.py
@@ -136,9 +136,11 @@ def get_remote_file(full_file_path, tag='master'):
 
     if full_file_path.endswith('json'):
         details = json.loads(res.content)
-    else:
+    elif full_file_path.endswith('yml'):
         details = yaml.safe_load(res.content)
-
+    # if neither yml nor json then probably a CHANGELOG or README file.
+    else:
+        details = {}
     return details