feat: removed escape of forward slash in json files #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build f0845d44-c5b9-48fd-8d44-930698ffd07c
💛 - Coveralls |
| dumped = JSON_Handler().dumps({'url': url}) | ||
| assert url in dumped, 'Could not find the url im the dumped file. Maybe escaped char?' | ||
|
|
||
| def test_no_escape_chars_dump(self, tmpdir): |
There was a problem hiding this comment.
Change function name
There was a problem hiding this comment.
that is exactly what the test does
There was a problem hiding this comment.
test_no_escape_chars_file_dump
There was a problem hiding this comment.
dump != dumps
it's pretty petty.
jochman
changed the title
dorschw
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: ultrajson/ultrajson#110
Description
a forward slash was esacpped, fixed it.
Screenshots
Paste here any images that will help the reviewer
Must have