Add functions from content #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2174
💛 - Coveralls |
IkaDemisto
reviewed
Mar 30, 2020
demisto_sdk/commands/common/tools.py
Outdated
| return tags[0] | ||
|
|
||
|
|
||
| def collect_pack_content_items(pack_path): |
There was a problem hiding this comment.
You can remove it, will be moved to store_packs
IkaDemisto
reviewed
Mar 30, 2020
demisto_sdk/commands/common/tools.py
Outdated
| return task_status, data | ||
|
|
||
|
|
||
| def input_to_list(input_data): |
|
@yuvalbenshalom The only addition here is the |
|
@liorblob do we need the |
|
@IkaDemisto Nope, should we move the class to that file? |
Yes, I think so. |
yuvalbenshalom
approved these changes
Mar 30, 2020
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready
Related Issues
https://github.com/demisto/etc/issues/22938
Description
As part of the content repo cleanup, we're moving all the constants and tools to the SDK so there will be no inconsistencies.