Added a graceful error message when executing the *run" command with … #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a misspelled command
Pull Request Test Coverage Report for Build 2146
💛 - Coveralls |
yaakovi
reviewed
Mar 29, 2020
|
|
||
| answer = self.client.investigation_add_entries_sync(update_entry=update_entry) | ||
| if not answer: | ||
| raise RuntimeError |
There was a problem hiding this comment.
don't raise a class, raise an object (with a proper descriptive message)
There was a problem hiding this comment.
correct.
fixed it, error looks ok.
(py37) ➜ content git:(securonix1_assign) ✗ demisto-sdk run -q 'securonix-list-incidentsss'
You are using demisto-sdk 0.4.9.dev14, however version 0.4.8 is available.
You should consider upgrading via "pip3 install --upgrade demisto-sdk" command.
Command did not run, make sure it was written correctly.
yaakovi
approved these changes
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a misspelled command
Status
Ready
Related Issues
fixes: https://github.com/demisto/etc/issues/22924