Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-guide-update #313

Merged
merged 2 commits into from
Mar 30, 2020
Merged

dev-guide-update #313

merged 2 commits into from
Mar 30, 2020

Conversation

bakatzir
Copy link
Member

Status

Ready

Description

added venv tips

@bakatzir bakatzir self-assigned this Mar 30, 2020
guyfreund
guyfreund suggested changes Mar 30, 2020
View reviewed changes
docs/development_guide.md Show resolved Hide resolved
docs/development_guide.md Outdated Show resolved Hide resolved
docs/development_guide.md Show resolved Hide resolved
@guyfreund guyfreund self-requested a review March 30, 2020 13:03
guyfreund
guyfreund approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@guyfreund guyfreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2159

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.63%
Totals Coverage Status
Change from base Build 2147: 0.0%
Covered Lines: 3382
Relevant Lines: 6426
💛 - Coveralls

@bakatzir bakatzir merged commit b6f5b2e into master Mar 30, 2020
@bakatzir bakatzir deleted the dev-guide-update branch March 30, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyfreund guyfreund guyfreund approved these changes

@yaakovi yaakovi Awaiting requested review from yaakovi

Assignees

@bakatzir bakatzir

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bakatzir @coveralls @guyfreund