Move ImageValidator and DescriptionValidator validations to IntegrationValidator #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaakovi
approved these changes
Apr 6, 2020
| @@ -66,15 +75,18 @@ def is_valid_file(self, validate_rn=True): | |||
| self.is_valid_fetch(), | |||
| self.is_valid_display_name(), | |||
| self.is_all_params_not_hidden(), | |||
| self.is_valid_image(), | |||
| self.is_valid_description(beta_integration=False) | |||
There was a problem hiding this comment.
Suggested change
| self.is_valid_description(beta_integration=False) | |
| self.is_valid_description(beta_integration=False), |
| """Check whether the beta Integration is valid or not, update the _is_valid field to determine that""" | ||
| answers = [ | ||
| self.is_valid_default_arguments(), | ||
| self.is_valid_beta(), | ||
| self.is_valid_image(), | ||
| self.is_valid_description(beta_integration=True) |
There was a problem hiding this comment.
Suggested change
| self.is_valid_description(beta_integration=True) | |
| self.is_valid_description(beta_integration=True), |
| Returns: | ||
| bool. True if there aren't hidden parameters False otherwise. | ||
| bool: True if description image/logo is valid, False otherwise. |
There was a problem hiding this comment.
Suggested change
| bool: True if description image/logo is valid, False otherwise. | |
| bool: True if integration description is valid, False otherwise. |
|
@yaakovi please see my changes:
|
Pull Request Test Coverage Report for Build 2322
💛 - Coveralls |
yaakovi
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Description
Moved
ImageValidatorandDescriptionValidatorvalidations fromfile_validatortointegrationMust have