Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - pipfile path #336

Merged
merged 12 commits into from
Apr 13, 2020
Merged

Bug - pipfile path #336

merged 12 commits into from
Apr 13, 2020

Conversation

GalRabin
Copy link
Contributor

@GalRabin GalRabin commented Apr 8, 2020 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

  • Fixing the path of pipfile corresponding to new lint command.
  • Fixing index changed files

@GalRabin GalRabin requested a review from Itay4 April 8, 2020 05:17
@coveralls
Copy link
Collaborator

coveralls commented Apr 8, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 2446

  • 7 of 10 (70.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 61.698%
Changes Missing Coverage Covered Lines Changed/Added Lines %
demisto_sdk/commands/lint/linter.py 3 4 75.0%
demisto_sdk/commands/lint/lint_manager.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/lint/linter.py 1 63.24%
demisto_sdk/commands/lint/lint_manager.py 1 23.34%
Totals Coverage Status
Change from base Build 2431: 0.0%
Covered Lines: 4710
Relevant Lines: 7634
💛 - Coveralls

@GalRabin GalRabin requested review from yaakovi and removed request for Itay4 April 8, 2020 06:33
@GalRabin GalRabin requested a review from Itay4 April 8, 2020 08:41
yaakovi
yaakovi approved these changes Apr 12, 2020
View reviewed changes
Copy link
Contributor

@yaakovi yaakovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure this is working for windows as well

demisto_sdk/commands/lint/linter.py Show resolved Hide resolved
demisto_sdk/commands/common/configuration.py Outdated Show resolved Hide resolved
@GalRabin GalRabin merged commit ccf04e0 into master Apr 13, 2020
@GalRabin GalRabin deleted the bug_split_yml branch April 13, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaakovi yaakovi yaakovi approved these changes

@Itay4 Itay4 Awaiting requested review from Itay4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@GalRabin @coveralls @yaakovi @grabin-dev