Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog update #341

Merged
merged 3 commits into from
Apr 12, 2020
Merged

Changelog update #341

merged 3 commits into from
Apr 12, 2020

Conversation

Shellyber
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

@Shellyber Shellyber requested a review from jochman April 12, 2020 08:44
@coveralls
Copy link
Collaborator

coveralls commented Apr 12, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 2421

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.228%
Totals Coverage Status
Change from base Build 2416: 0.0%
Covered Lines: 4593
Relevant Lines: 7626
💛 - Coveralls

jochman
jochman suggested changes Apr 12, 2020
View reviewed changes
CHANGELOG.md Outdated
@@ -1,5 +1,11 @@
# Changelog
* Fixed secretes validations for files with the same name in a different directory
#changelog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#changelog
# Changelog

jochman
jochman approved these changes Apr 12, 2020
View reviewed changes
Copy link
Contributor

@jochman jochman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Shellyber Shellyber merged commit 1c51828 into master Apr 12, 2020
@Shellyber Shellyber deleted the changelog-update branch April 12, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jochman jochman jochman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Shellyber @coveralls @jochman