Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed validation for price in pack metadata #342

Merged
merged 28 commits into from
Apr 13, 2020
Merged

Conversation

Shellyber
Copy link
Contributor

@Shellyber Shellyber commented Apr 12, 2020

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://github.com/demisto/etc/issues/23232

Must have

  • Tests

@coveralls
Copy link
Collaborator

coveralls commented Apr 12, 2020

Pull Request Test Coverage Report for Build 2474

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 61.826%

Totals Coverage Status
Change from base Build 2447: 0.1%
Covered Lines: 4713
Relevant Lines: 7623

💛 - Coveralls

@Shellyber Shellyber requested a review from Itay4 April 12, 2020 10:17
@Itay4
Copy link
Contributor

Itay4 commented Apr 12, 2020

please add TODO in all the places your commented out the code

@Shellyber
Copy link
Contributor Author

@Itay4 Added the TODO comments.
Opened the following issue - https://github.com/demisto/etc/issues/23546

@Shellyber Shellyber merged commit 7997e8c into master Apr 13, 2020
@Shellyber Shellyber deleted the price-tag-fix branch April 13, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants