Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when running on Windows #3950

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Warn when running on Windows #3950

merged 2 commits into from
Jan 16, 2024

Conversation

dorschw
Copy link
Contributor

@dorschw dorschw commented Jan 15, 2024

Related Issues

related: XSUP-32254

Description

  • Add a warning log when running on Windows machines
  • Update README.md

@coveralls
Copy link
Collaborator

coveralls commented Jan 15, 2024

Pull Request Test Coverage Report for Build 1644d51b-64a6-4898-87c0-71d16e923f97

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8002 unchanged lines in 290 files lost coverage.
  • Overall coverage decreased (-18.5%) to 80.398%

Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/common/clients/configs.py 1 97.14%
demisto_sdk/commands/common/content/objects/pack_objects/incident_field/incident_field.py 1 65.0%
demisto_sdk/commands/common/content/objects/pack_objects/job/job.py 1 83.33%
demisto_sdk/commands/common/content/objects/pack_objects/lists/lists.py 1 85.71%
demisto_sdk/commands/common/files/errors.py 1 71.43%
demisto_sdk/commands/common/files/text_file.py 1 78.13%
demisto_sdk/commands/common/hook_validations/deprecation.py 1 98.72%
demisto_sdk/commands/common/hook_validations/job.py 1 98.41%
demisto_sdk/commands/common/hook_validations/layout_rule.py 1 88.89%
demisto_sdk/commands/common/hook_validations/lists.py 1 96.55%
Totals Coverage Status
Change from base Build 7520387020: -18.5%
Covered Lines: 35253
Relevant Lines: 43848

💛 - Coveralls

Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, need a change-log here IMO

@dorschw dorschw merged commit b0f1b03 into master Jan 16, 2024
29 checks passed
@dorschw dorschw deleted the ds-warn-winOS branch January 16, 2024 08:17
@tschanfeld
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants