Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt Docker Proxy #3975

Merged
merged 20 commits into from Jan 31, 2024
Merged

Adapt Docker Proxy #3975

merged 20 commits into from Jan 31, 2024

Conversation

michal-dagan
Copy link
Contributor

@michal-dagan michal-dagan commented Jan 24, 2024 •
edited

@coveralls
Copy link
Collaborator

coveralls commented Jan 24, 2024 •
edited

Pull Request Test Coverage Report for Build 6bfca1ab-6dfa-4f1d-8f42-319775088a80

  • 2 of 5 (40.0%) changed or added relevant lines in 2 files are covered.
  • 8020 unchanged lines in 291 files lost coverage.
  • Overall coverage decreased (-18.3%) to 80.589%
Changes Missing Coverage Covered Lines Changed/Added Lines %
demisto_sdk/commands/common/docker_helper.py 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/common/clients/configs.py 1 97.14%
demisto_sdk/commands/common/content/objects/pack_objects/incident_field/incident_field.py 1 65.0%
demisto_sdk/commands/common/content/objects/pack_objects/job/job.py 1 83.33%
demisto_sdk/commands/common/content/objects/pack_objects/lists/lists.py 1 85.71%
demisto_sdk/commands/common/files/errors.py 1 71.43%
demisto_sdk/commands/common/files/text_file.py 1 78.13%
demisto_sdk/commands/common/hook_validations/deprecation.py 1 98.72%
demisto_sdk/commands/common/hook_validations/job.py 1 98.41%
demisto_sdk/commands/common/hook_validations/layout_rule.py 1 88.89%
demisto_sdk/commands/common/hook_validations/lists.py 1 96.55%
Totals Coverage Status
Change from base Build 7694890770: -18.3%
Covered Lines: 35763
Relevant Lines: 44377
💛 - Coveralls

@michal-dagan michal-dagan mentioned this pull request Jan 30, 2024
Merged
5 tasks
DeanArbel
DeanArbel approved these changes Jan 31, 2024
View reviewed changes
demisto_sdk/commands/common/constants.py Outdated
@@ -24,6 +24,7 @@
"CI_PROJECT_ID", "1061"
) # Default value is the ID of the content repo on GitLab
ENV_SDK_WORKING_OFFLINE = "DEMISTO_SDK_OFFLINE_ENV"
DOCKER_REGISTRY_URL = os.getenv("DOCKER_IO", "docker-io.art.code.pan.run")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to docker.io

@michal-dagan michal-dagan changed the title Adapt docker Adapt Docker Proxy Jan 31, 2024
ilaner
ilaner approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@ilaner ilaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@michal-dagan michal-dagan merged commit cb6be8d into master Jan 31, 2024
33 checks passed
@michal-dagan michal-dagan deleted the adapt-docker branch January 31, 2024 10:52
This was referenced Jan 31, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeanArbel DeanArbel DeanArbel approved these changes

@ilaner ilaner ilaner approved these changes

@GuyAfik GuyAfik Awaiting requested review from GuyAfik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@michal-dagan @coveralls @DeanArbel @ilaner