Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_logs_dir_not_a_dir integration-test #3987

Merged
merged 3 commits into from
Jan 28, 2024
Merged

Fix test_logs_dir_not_a_dir integration-test #3987

merged 3 commits into from
Jan 28, 2024

Conversation

MichaelYochpaz
Copy link
Contributor

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9580

Description

Fix failing test_logs_dir_not_a_dir integration test

@coveralls
Copy link
Collaborator

coveralls commented Jan 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 0c9f697a-9090-4147-961d-855f76d6d1e8

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 164 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 80.535%
Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/common/tools.py 164 81.0%
Totals Coverage Status
Change from base Build 0f24f7fc-e859-44a0-93c1-44784ba5d728: -0.001%
Covered Lines: 35631
Relevant Lines: 44243
💛 - Coveralls

@MichaelYochpaz MichaelYochpaz force-pushed the logger-integration-test-fix branch 3 times, most recently from dc0595a to 065a959 Compare January 28, 2024 08:28
@MichaelYochpaz MichaelYochpaz marked this pull request as ready for review January 28, 2024 09:02
GuyAfik
GuyAfik approved these changes Jan 28, 2024
View reviewed changes
Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@MichaelYochpaz MichaelYochpaz merged commit b3a6f3e into master Jan 28, 2024
30 of 31 checks passed
@MichaelYochpaz MichaelYochpaz deleted the logger-integration-test-fix branch January 28, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuyAfik GuyAfik GuyAfik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MichaelYochpaz @coveralls @GuyAfik