Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support asset collection #4005

Merged
merged 7 commits into from
Feb 28, 2024
Merged

support asset collection #4005

merged 7 commits into from
Feb 28, 2024

Conversation

merit-maita
Copy link
Contributor

@merit-maita merit-maita commented Jan 31, 2024 •
edited
Loading

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9635

Description

  • added description to assets collection content item
  • add validations to assets collection name to have "Asset Collection" suffix.

@coveralls
Copy link
Collaborator

coveralls commented Jan 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8004298723

Details

  • 0 of 21 (100.0%) changed or added relevant lines in 5 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+11.4%) to 92.095%
Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/content_graph/neo4j_service.py 3 95.92%
demisto_sdk/commands/content_graph/commands/common.py 5 58.82%
Totals Coverage Status
Change from base Build fe003b46-a4bc-4dff-bca9-ebcc92903b25: 11.4%
Covered Lines: 57762
Relevant Lines: 62720
💛 - Coveralls

@merit-maita merit-maita changed the title fixes for displaying items support asset collection Feb 1, 2024
@merit-maita merit-maita marked this pull request as ready for review February 20, 2024 11:56
@dantavori dantavori removed their request for review February 26, 2024 19:08
@merit-maita merit-maita merged commit b3b8fd6 into master Feb 28, 2024
34 checks passed
@merit-maita merit-maita deleted the assets_upload_support branch February 28, 2024 10:36
@adi88d adi88d mentioned this pull request Mar 3, 2024
Merged
@content-bot content-bot mentioned this pull request Mar 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thefrieddan1 thefrieddan1 thefrieddan1 approved these changes

@ilaner ilaner Awaiting requested review from ilaner

@YuvHayun YuvHayun Awaiting requested review from YuvHayun YuvHayun is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@merit-maita @coveralls @thefrieddan1