Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added handle_error for mdx_server, and logging configurations #4048

Merged
merged 25 commits into from Feb 21, 2024

Conversation

anas-yousef
Copy link
Contributor

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-32560

Description

Added the handle_error option when checking if the mdx server is up fails.

@coveralls
Copy link
Collaborator

coveralls commented Feb 15, 2024

Pull Request Test Coverage Report for Build 510b675c-3a86-4d7f-bac3-54839a3bff54

Details

  • 4 of 9 (44.44%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.004%) to 80.697%

Changes Missing Coverage Covered Lines Changed/Added Lines %
demisto_sdk/commands/common/hook_validations/readme.py 1 6 16.67%
Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/common/clients/xsoar/xsoar_api_client.py 1 40.69%
demisto_sdk/commands/common/content/objects/pack_objects/pack_metadata/pack_metadata.py 1 95.64%
demisto_sdk/commands/common/docker_helper.py 1 63.43%
demisto_sdk/commands/common/hook_validations/graph_validator.py 1 24.1%
Totals Coverage Status
Change from base Build 00578831-be41-4404-8916-50cc3dc4853a: -0.004%
Covered Lines: 36885
Relevant Lines: 45708

💛 - Coveralls

Copy link

Changelog(s) in markdown:

  • Fixed an issue where validate would fail from trying to connect to MDX server without stating the reason. #4048

.changelog/4048.yml Outdated Show resolved Hide resolved
@anas-yousef anas-yousef requested review from JudahSchwartz and removed request for idovandijk February 19, 2024 11:57
Copy link
Contributor

@JudahSchwartz JudahSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you checked manually that this skip works as you described right?

demisto_sdk/commands/common/hook_validations/readme.py Outdated Show resolved Hide resolved
@anas-yousef anas-yousef merged commit 48a4a70 into master Feb 21, 2024
33 checks passed
@anas-yousef anas-yousef deleted the ay-add-handle-error-to-mdx-server branch February 21, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants