New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added handle_error for mdx_server, and logging configurations #4048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 510b675c-3a86-4d7f-bac3-54839a3bff54Details
💛 - Coveralls |
Changelog(s) in markdown:
|
…o/demisto-sdk into ay-add-handle-error-to-mdx-server
dorschw
reviewed
Feb 15, 2024
dorschw
reviewed
Feb 18, 2024
…andle-error-to-mdx-server
…andle-error-to-mdx-server
…andle-error-to-mdx-server
anas-yousef
requested review from
JudahSchwartz
and removed request for
idovandijk
February 19, 2024 11:57
JudahSchwartz
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you checked manually that this skip works as you described right?
…andle-error-to-mdx-server
…o/demisto-sdk into ay-add-handle-error-to-mdx-server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-32560
Description
Added the handle_error option when checking if the mdx server is up fails.