Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK] - do not fail if repo isn't git #4088

Merged
merged 7 commits into from
Feb 28, 2024
Merged

[SDK] - do not fail if repo isn't git #4088

merged 7 commits into from
Feb 28, 2024

Conversation

GuyAfik
Copy link
Contributor

@GuyAfik GuyAfik commented Feb 26, 2024 •
edited

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9790

Description

Fixes issue where SDK would crash when running on repositories which are not git.

@GuyAfik GuyAfik requested a review from ilaner February 26, 2024 12:39
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Fixed an issue where SDK would crash when running on repoitories which do not git configured. #4088

@coveralls
Copy link
Collaborator

coveralls commented Feb 26, 2024 •
edited

Pull Request Test Coverage Report for Build 8070722501

Details

  • 0 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+11.4%) to 92.108%
Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/content_graph/neo4j_service.py 3 95.92%
demisto_sdk/commands/content_graph/commands/common.py 5 58.82%
Totals Coverage Status
Change from base Build 182f2138-4780-4bd5-80f3-60edbaaef877: 11.4%
Covered Lines: 57970
Relevant Lines: 62937
💛 - Coveralls

@GuyAfik GuyAfik marked this pull request as ready for review February 26, 2024 13:15
@GuyAfik GuyAfik changed the title [files] - do not fail if repo isn't git [SDK] - do not fail if repo isn't git Feb 26, 2024
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Fixed an issue where SDK would crash when running on repoitories which do not have git configured. #4088

@GuyAfik GuyAfik marked this pull request as draft February 26, 2024 16:32
@GuyAfik GuyAfik force-pushed the try_except_file_git_util branch 2 times, most recently from 18abde2 to abd476d Compare February 27, 2024 19:24
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Fixed an issue where SDK would crash when running on repoitories which do not have git configured. #4088

@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Fixed an issue where SDK would crash when running on repoitories which do not have git configured. #4088
  • Fixed an issue where reading files on repositories which are not git repositories failed when the path provided was relative path. #4088

@GuyAfik GuyAfik marked this pull request as ready for review February 28, 2024 07:09
@GuyAfik GuyAfik merged commit edfeb01 into master Feb 28, 2024
35 checks passed
@GuyAfik GuyAfik deleted the try_except_file_git_util branch February 28, 2024 07:09
@adi88d adi88d mentioned this pull request Mar 3, 2024
Merged
@content-bot content-bot mentioned this pull request Mar 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilaner ilaner ilaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@GuyAfik @coveralls @ilaner