Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Validate] Refactor GF #4092

Merged
merged 12 commits into from Mar 21, 2024
Merged

[Validate] Refactor GF #4092

merged 12 commits into from Mar 21, 2024

Conversation

israelpoli
Copy link
Contributor

@israelpoli israelpoli commented Feb 27, 2024 •
edited

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-10052

Description

@coveralls
Copy link
Collaborator

coveralls commented Feb 27, 2024 •
edited

Pull Request Test Coverage Report for Build 4872681a-de0d-4fcd-86c9-8793a47f5828

Details

  • 37 of 39 (94.87%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 80.741%
Changes Missing Coverage Covered Lines Changed/Added Lines %
demisto_sdk/commands/validate/validators/GF_validators/GF100_generic_field_group.py 17 19 89.47%
Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/common/hook_validations/graph_validator.py 1 24.1%
demisto_sdk/commands/content_graph/objects/content_item.py 2 77.84%
Totals Coverage Status
Change from base Build 182f2138-4780-4bd5-80f3-60edbaaef877: 0.01%
Covered Lines: 37077
Relevant Lines: 45921
💛 - Coveralls

@israelpoli israelpoli requested review from YuvHayun and dorschw and removed request for dantavori and ilaner March 21, 2024 14:28
dorschw
dorschw reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@dorschw dorschw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! see the few comments.

demisto_sdk/commands/validate/tests/GF_validators_test.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/tests/GF_validators_test.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/validators/GF_validators/GF100_generic_field_group.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/validators/GF_validators/GF100_generic_field_group.py Outdated Show resolved Hide resolved
...sto_sdk/commands/validate/validators/GF_validators/GF101_generic_field_id_prefix_validate.py Outdated Show resolved Hide resolved
...sto_sdk/commands/validate/validators/GF_validators/GF101_generic_field_id_prefix_validate.py Outdated Show resolved Hide resolved
...sto_sdk/commands/validate/validators/GF_validators/GF101_generic_field_id_prefix_validate.py Outdated Show resolved Hide resolved
YuvHayun
YuvHayun approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Achla IP!
Make sure to change the tests according to the changes in the validations.

demisto_sdk/commands/content_graph/parsers/generic_field.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/validators/GF_validators/GF100_generic_field_group.py Outdated Show resolved Hide resolved
...sto_sdk/commands/validate/validators/GF_validators/GF101_generic_field_id_prefix_validate.py Outdated Show resolved Hide resolved
...sto_sdk/commands/validate/validators/GF_validators/GF101_generic_field_id_prefix_validate.py Outdated Show resolved Hide resolved
...sto_sdk/commands/validate/validators/GF_validators/GF101_generic_field_id_prefix_validate.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/tests/GF_validators_test.py Outdated Show resolved Hide resolved
@israelpoli israelpoli requested a review from dorschw March 21, 2024 15:21
@israelpoli israelpoli merged commit 956f98e into master Mar 21, 2024
21 of 22 checks passed
@israelpoli israelpoli deleted the GF_validate_refactor branch March 21, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuvHayun YuvHayun YuvHayun approved these changes

@dorschw dorschw dorschw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@israelpoli @coveralls @YuvHayun @dorschw