Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lint] - fixed an issue where lint would crash without internet connectivity #4098

Merged
merged 6 commits into from
Feb 29, 2024
Merged

[lint] - fixed an issue where lint would crash without internet connectivity #4098

merged 6 commits into from
Feb 29, 2024

Conversation

GuyAfik
Copy link
Contributor

@GuyAfik GuyAfik commented Feb 29, 2024 •
edited

@GuyAfik GuyAfik changed the title Support offline env var [lint] - fixed an issue where lint would crash without internet connectivity Feb 29, 2024
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Fixed an issue where lint failed when there was not internet connection. #4098

@GuyAfik GuyAfik mentioned this pull request Feb 29, 2024
Merged
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Fixed an issue where lint would crash without internet connectivity. #4098

@GuyAfik GuyAfik requested a review from dorschw February 29, 2024 06:44
@coveralls
Copy link
Collaborator

coveralls commented Feb 29, 2024 •
edited

Pull Request Test Coverage Report for Build 8097831355

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+11.5%) to 92.151%
Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/content_graph/neo4j_service.py 3 95.92%
demisto_sdk/commands/content_graph/commands/common.py 5 58.82%
Totals Coverage Status
Change from base Build f8058cf0-1b17-4ecb-86dc-9cac78d59a37: 11.5%
Covered Lines: 58315
Relevant Lines: 63282
💛 - Coveralls

@GuyAfik GuyAfik requested a review from ilaner February 29, 2024 10:52
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Fixed an issue where lint would crash without internet connectivity. #4098

@GuyAfik GuyAfik requested a review from dorschw February 29, 2024 14:32
@GuyAfik GuyAfik merged commit 4a27840 into master Feb 29, 2024
34 checks passed
@GuyAfik GuyAfik deleted the support_offline_env_var branch February 29, 2024 15:19
@adi88d adi88d mentioned this pull request Mar 3, 2024
Merged
@content-bot content-bot mentioned this pull request Mar 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorschw dorschw dorschw approved these changes

@ilaner ilaner Awaiting requested review from ilaner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@GuyAfik @coveralls @dorschw