Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[validate-deleted-files-hook] - add logging setup #4099

Merged
merged 1 commit into from Feb 29, 2024

Conversation

GuyAfik
Copy link
Contributor

@GuyAfik GuyAfik commented Feb 29, 2024

Description

Add logging setup to validate-deleted-files hook.

@coveralls
Copy link
Collaborator

coveralls commented Feb 29, 2024

Pull Request Test Coverage Report for Build 7118b4e3-9eb9-44f7-b107-0c630983fc48

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 5 files lost coverage.
  • Overall coverage remained the same at 80.633%

Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/common/clients/xsoar/xsoar_api_client.py 1 40.78%
demisto_sdk/commands/common/content/objects/pack_objects/pack_metadata/pack_metadata.py 1 95.64%
demisto_sdk/commands/common/docker_helper.py 1 63.43%
demisto_sdk/commands/common/hook_validations/graph_validator.py 1 24.1%
demisto_sdk/commands/content_graph/objects/content_item.py 2 77.84%
Totals Coverage Status
Change from base Build 1de70fbb-d908-4f97-a73f-fb12554e4a79: 0.0%
Covered Lines: 37146
Relevant Lines: 46068

💛 - Coveralls

@GuyAfik GuyAfik requested a review from ilaner February 29, 2024 08:47
@GuyAfik GuyAfik merged commit 3d559ff into master Feb 29, 2024
35 of 36 checks passed
@GuyAfik GuyAfik deleted the validate_deleted_files_hook_logging branch February 29, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants