Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker Error Message To Reflect Different Issues #4101

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

MichaelYochpaz
Copy link
Contributor

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9851

Description

We currently print the same error for all Docker exceptions, even though there can be different errors.
This causes a lot of confusion when debugging errors.
This PR resolves it by raising the original error.

@coveralls
Copy link
Collaborator

coveralls commented Feb 29, 2024

Pull Request Test Coverage Report for Build a73dcfd0-e84e-406f-9587-df95e651d34f

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.001%) to 80.634%

Changes Missing Coverage Covered Lines Changed/Added Lines %
demisto_sdk/commands/common/docker_helper.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/common/clients/xsoar/xsoar_api_client.py 1 39.81%
demisto_sdk/commands/common/content/objects/pack_objects/pack_metadata/pack_metadata.py 1 95.64%
demisto_sdk/commands/common/docker_helper.py 1 63.64%
demisto_sdk/commands/common/update_id_set.py 1 85.85%
demisto_sdk/commands/doc_reviewer/rn_checker.py 1 67.83%
demisto_sdk/commands/run_test_playbook/test_playbook_runner.py 1 76.56%
demisto_sdk/commands/update_release_notes/update_rn_manager.py 1 92.5%
Totals Coverage Status
Change from base Build 1de70fbb-d908-4f97-a73f-fb12554e4a79: 0.001%
Covered Lines: 37145
Relevant Lines: 46066

💛 - Coveralls

@MichaelYochpaz MichaelYochpaz merged commit 741f3bf into master Feb 29, 2024
33 of 34 checks passed
@MichaelYochpaz MichaelYochpaz deleted the fix-docker-error-message branch February 29, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants