Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to months #4119

Merged
merged 6 commits into from
Mar 7, 2024
Merged

change to months #4119

merged 6 commits into from
Mar 7, 2024

Conversation

JudahSchwartz
Copy link
Contributor

@JudahSchwartz JudahSchwartz commented Mar 7, 2024

primary focus on this validation should no longer be that the image youre using is the latest, it should be that your image isnt outdated. Outdated is > 3 months
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9920

@JudahSchwartz JudahSchwartz requested review from GuyAfik and removed request for idovandijk and YuvHayun March 7, 2024 13:21
Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JudahSchwartz looks good, please only add a changelog

@coveralls
Copy link
Collaborator

coveralls commented Mar 7, 2024

Pull Request Test Coverage Report for Build 8189842368

Details

  • 9 of 11 (81.82%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+11.6%) to 92.215%

Changes Missing Coverage Covered Lines Changed/Added Lines %
demisto_sdk/commands/validate/validators/DO_validators/DO106_docker_image_is_latest_tag.py 6 8 75.0%
Totals Coverage Status
Change from base Build 8bef0368-d938-4718-afc6-c00f2fd570a3: 11.6%
Covered Lines: 59107
Relevant Lines: 64097

💛 - Coveralls

.changelog/4119.yml Outdated Show resolved Hide resolved
.changelog/4119.yml Outdated Show resolved Hide resolved
JudahSchwartz and others added 2 commits March 7, 2024 16:33
Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com>
Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com>
Copy link

github-actions bot commented Mar 7, 2024

Changelog(s) in markdown:

  • Updated the DO106 error code in the validate command to not fail when a docker image is younger than 3 months instead of 3 days. #4119

@JudahSchwartz JudahSchwartz merged commit adf74b9 into master Mar 7, 2024
34 checks passed
@JudahSchwartz JudahSchwartz deleted the change_validation_three_months branch March 7, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants