Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YR/ Convert validation to the new format / BC103/ CIAC-10000 #4153

Merged
merged 22 commits into from
Apr 13, 2024

Conversation

RosenbergYehuda
Copy link
Contributor

@RosenbergYehuda RosenbergYehuda commented Mar 20, 2024

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-10000

Description

Convert validation to the new format.
The validation validates that the script arguments name did not change.

@RosenbergYehuda RosenbergYehuda changed the title YR/BC103/CIAC-10000 YR/ Convert validation to the new format / BC103/ CIAC-10000 Mar 20, 2024
@RosenbergYehuda RosenbergYehuda requested review from JasBeilin and YuvHayun and removed request for YuvHayun and JasBeilin March 20, 2024 15:27
@RosenbergYehuda RosenbergYehuda self-assigned this Apr 1, 2024
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, minor comments.

Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.
@JasBeilin approved from my side.

Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, see my comments.

Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

@RosenbergYehuda RosenbergYehuda merged commit 42c819b into master Apr 13, 2024
23 of 24 checks passed
@RosenbergYehuda RosenbergYehuda deleted the YR/BC103/CIAC-10000 branch April 13, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants