-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YR/ Convert validation to the new format / BC103/ CIAC-10000 #4153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, minor comments.
demisto_sdk/commands/validate/validators/BC_validators/BC103_have_the_args_changed.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/BC_validators/BC103_have_the_args_changed.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
@JasBeilin approved from my side.
demisto_sdk/commands/validate/validators/BC_validators/BC103_have_the_args_changed.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, see my comments.
demisto_sdk/commands/validate/validators/BC_validators/BC103_have_the_args_changed.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/BC_validators/BC103_have_the_args_changed.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great.
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-10000
Description
Convert validation to the new format.
The validation validates that the script arguments name did not change.