Graph - reuse parse content dto, skip empty packs #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuyAfik
approved these changes
Mar 20, 2024
| logger.debug( | ||
| f'DEMISTO_SDK_GRAPH_FORCE_CREATE = {os.getenv("DEMISTO_SDK_GRAPH_FORCE_CREATE")}' | ||
| ) | ||
| if os.getenv("DEMISTO_SDK_GRAPH_FORCE_CREATE") == "true": |
There was a problem hiding this comment.
put inside a variable and reuse it also in the line 76
| @@ -17,25 +18,41 @@ | |||
| USE_MULTIPROCESSING = False # toggle this for better debugging | |||
|
|
|||
|
|
|||
| @lru_cache | |||
| def from_path(path: Path = CONTENT_PATH, packs_to_parse: Optional[Tuple[str]] = None): | |||
There was a problem hiding this comment.
why isn't it a class method of ContentDTO?
There was a problem hiding this comment.
I documented, for some reason I get cache miss whin it's in the class.
Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com>
Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com>
…misto/demisto-sdk into skip_graph_validation_on_old_validate
…on_on_old_validate
|
Changelog(s) in markdown:
|
This was referenced Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following:
ContentDTO.from_path, so if the content was parsed in the sdk run, it will not parsefixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9717