Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Generate Docs for new Integration in Existing Pack #4162

Merged
merged 5 commits into from Mar 24, 2024
Merged

Fix Generate Docs for new Integration in Existing Pack #4162

merged 5 commits into from Mar 24, 2024

Conversation

kgal-pan
Copy link
Contributor

@kgal-pan kgal-pan commented Mar 21, 2024 •
edited

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-10048

Description

Fixes an issue when a new integration exists in the local filesystem is considered an existing integration.

@kgal-pan kgal-pan requested a review from GuyAfik March 21, 2024 14:33
GuyAfik
GuyAfik reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgal-pan Add a changelog + lets make the FileNotFound errors to be debug logs instead of error.

demisto_sdk/commands/generate_docs/generate_integration_doc.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Fix a bug in generate-docs for new integrations in existing Packs. #4162

@kgal-pan kgal-pan requested a review from GuyAfik March 21, 2024 15:16
GuyAfik
GuyAfik reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgal-pan lets also update the log of FileNotFound to debug?

.changelog/4162.yml Outdated Show resolved Hide resolved
@kgal-pan kgal-pan requested a review from GuyAfik March 24, 2024 11:09
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Fixed an issue where generate-docs command didn't work on newly-created integrations in existing Packs. #4162

GuyAfik
GuyAfik approved these changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@kgal-pan kgal-pan merged commit eceed86 into master Mar 24, 2024
22 checks passed
@kgal-pan kgal-pan deleted the test-code42-collector-gen-docs branch March 24, 2024 11:51
This was referenced Mar 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuyAfik GuyAfik GuyAfik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kgal-pan @GuyAfik