YR/-BC-104-New-format-validation/CIAC-10001 #4187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reated-successfully/CIAC-9913
…reated-successfully/CIAC-9913
…reated-successfully/CIAC-9913
…reated-successfully/CIAC-9913
…reated-successfully/CIAC-9913
…reated-successfully/CIAC-9913
…at-validation/CIAC-10001
Base automatically changed from
YR/test-graph-was-created-successfully/CIAC-9913
to
master
March 27, 2024 13:56
RosenbergYehuda
requested review from
YuvHayun and
JasBeilin
and removed request for
dantavori and
ilaner
YuvHayun
requested changes
Apr 3, 2024
demisto_sdk/commands/validate/validators/BC_validators/BC110_new_required_argument.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/BC_validators/BC110_new_required_argument.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/BC_validators/BC110_new_required_argument.py
Outdated
Show resolved
Hide resolved
...o_sdk/commands/validate/validators/BC_validators/BC104_have_commands_or_args_name_changed.py
Outdated
Show resolved
Hide resolved
YuvHayun
approved these changes
Apr 4, 2024
demisto_sdk/commands/validate/validators/BC_validators/BC110_new_required_argument.py
Outdated
Show resolved
Hide resolved
...o_sdk/commands/validate/validators/BC_validators/BC104_have_commands_or_args_name_changed.py
Outdated
Show resolved
Hide resolved
JasBeilin
requested changes
Apr 7, 2024
...o_sdk/commands/validate/validators/BC_validators/BC104_have_commands_or_args_name_changed.py
Show resolved
Hide resolved
JasBeilin
approved these changes
Apr 11, 2024
| @@ -54,7 +54,8 @@ | |||
|
|
|||
|
|
|||
| # Create a new content item with 3 commands with unique names. all commands have only 1 argument except the third command which has 2 arguments. | |||
| generic_integration_with_3_commands_and_4_args = create_integration_object( | |||
|
|
|||
| GENERIC_INTEGRATION_WITH_3_COMMANDS_AND_4_ARGS = create_integration_object( | |||
There was a problem hiding this comment.
Why is the number of args & command important here? cant we call it just DUMMY_INTEGRATION?
There was a problem hiding this comment.
I think it helps to understand the test, especially when i am adding a new arg, so it is clear to know what did we have before and what we have now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-10001
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-10114
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9694
Description
Convert half of BC 104 to the new format. This validation ensures that the names of existing commands or arguments have not been changed.
Furthermore, a new validation, BC110, was introduced following the split of BC104. This validation ensures that non-required arguments are not converted into required ones and that new arguments cannot be made mandatory.