Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IM101 #4199

Merged
merged 10 commits into from
Apr 11, 2024
Merged

IM101 #4199

merged 10 commits into from
Apr 11, 2024

Conversation

BEAdi
Copy link
Contributor

@BEAdi BEAdi commented Apr 1, 2024

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9799

Description

Validate refactor- IM101 check that image is not too large

@BEAdi BEAdi self-assigned this Apr 1, 2024
Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
Please see my comments.

Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
minor comments.

# Conflicts:
#	demisto_sdk/commands/validate/sdk_validation_config.toml
#	demisto_sdk/commands/validate/tests/IM_validators_test.py
Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@BEAdi BEAdi merged commit c3f8882 into master Apr 11, 2024
23 of 24 checks passed
@BEAdi BEAdi deleted the im101 branch April 11, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants