-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IM101 #4199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Please see my comments.
demisto_sdk/commands/validate/validators/IM_validators/IM101_image_too_large.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
minor comments.
demisto_sdk/commands/validate/validators/IM_validators/IM101_image_too_large.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/IM_validators/IM101_image_too_large.py
Outdated
Show resolved
Hide resolved
# Conflicts: # demisto_sdk/commands/validate/sdk_validation_config.toml # demisto_sdk/commands/validate/tests/IM_validators_test.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9799
Description
Validate refactor- IM101 check that image is not too large