-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YR/-Convert-IN116-into-BC111/CIAC-10243 #4207
YR/-Convert-IN116-into-BC111/CIAC-10243 #4207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, see my comments as we discussed.
demisto_sdk/commands/validate/validators/BC_validators/BC111_new_required_argument_script.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/BC_validators/BC111_new_required_argument_script.py
Outdated
Show resolved
Hide resolved
…nto-BC111/CIAC-10243
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I think we should improve our test's descriptions - see my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-10243
Description
Convert the IN116 validation, to the new format. Now it will be called BC111