Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YR/-Convert-IN116-into-BC111/CIAC-10243 #4207

Merged
merged 10 commits into from
Apr 14, 2024

Conversation

RosenbergYehuda
Copy link
Contributor

@RosenbergYehuda RosenbergYehuda commented Apr 4, 2024

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-10243

Description

Convert the IN116 validation, to the new format. Now it will be called BC111

Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, see my comments as we discussed.

Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I think we should improve our test's descriptions - see my comments.

demisto_sdk/commands/validate/tests/BC_validators_test.py Outdated Show resolved Hide resolved
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@RosenbergYehuda RosenbergYehuda merged commit 99d1305 into master Apr 14, 2024
23 of 24 checks passed
@RosenbergYehuda RosenbergYehuda deleted the YR/-Convert-IN116-into-BC111/CIAC-10243 branch April 14, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants