Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dump api command #4214

Merged
merged 8 commits into from
Apr 10, 2024
Merged

add dump api command #4214

merged 8 commits into from
Apr 10, 2024

Conversation

ilaner
Copy link
Contributor

@ilaner ilaner commented Apr 8, 2024

add dump api command to dump demisto-sdk commands api

@ilaner ilaner requested a review from GuyAfik as a code owner April 8, 2024 14:21
Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, small comments



@export_app.command(
context_settings={"allow_extra_args": True, "ignore_unknown_options": True},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add description for the command

@@ -3809,5 +3810,41 @@ def xsoar_linter(
main.add_command(typer.main.get_command(xsoar_linter_app), "xsoar-lint")


# ====================== export ====================== #

export_app = typer.Typer(name="dump-api")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export_app = typer.Typer(name="dump-api")
export_app = typer.Typer(name="sdk-api")

@export_app.command(
context_settings={"allow_extra_args": True, "ignore_unknown_options": True},
)
def dump_api(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def dump_api(
def sdk_api(

@ilaner ilaner merged commit 623aceb into master Apr 10, 2024
24 checks passed
@ilaner ilaner deleted the export_command branch April 10, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants