Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setup env test collection #4219

Merged
merged 11 commits into from Apr 9, 2024
Merged

Fix setup env test collection #4219

merged 11 commits into from Apr 9, 2024

Conversation

ilaner
Copy link
Contributor

@ilaner ilaner commented Apr 9, 2024 •
edited

fixes the following:

  • This will create a seperate .env for the docker run. We have to use it because the path are different between the host and container
  • Change to use debugpy in luanch since python debugging is deprecated.

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-10277

@ilaner ilaner requested a review from GuyAfik April 9, 2024 09:36
@ilaner ilaner changed the title Fix setup env Fix setup env test collection Apr 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Changelog(s) in markdown:

  • Fixed an issue where tests were not collected in VSCode after setup-env #4219

GuyAfik
GuyAfik approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

@ilaner ilaner merged commit 8b2c09d into master Apr 9, 2024
23 checks passed
@ilaner ilaner deleted the add_env_to_launch_setup_env branch April 9, 2024 15:09
This was referenced Apr 14, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuyAfik GuyAfik GuyAfik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ilaner @GuyAfik