Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentItemXSIAM default fromversion is now 8.0.0 #4243

Merged
merged 12 commits into from
May 15, 2024

Conversation

thefrieddan1
Copy link
Contributor

Related Issues

fixes: link to issue

Description

@thefrieddan1 thefrieddan1 marked this pull request as ready for review April 24, 2024 10:19
Copy link

Changelog(s) in markdown:

  • Change the minimum version of ContentItemXSIAM to 8.0.0 #4243

Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix tests

.changelog/4243.yml Outdated Show resolved Hide resolved
Copy link

Changelog(s) in markdown:

  • Change the default fromversion of XSIAM content items to 8.0.0 #4243

@thefrieddan1 thefrieddan1 marked this pull request as draft May 12, 2024 08:50
@thefrieddan1 thefrieddan1 marked this pull request as ready for review May 15, 2024 04:30
@thefrieddan1
Copy link
Contributor Author

SDK nightly passed successfully ( besides unrelated failure on slack notification )

Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, see note

Comment on lines -900 to -903
"XSIAMDashboards/xsiamdashboard-MyDashboard.json",
"XSIAMDashboards/external-xsiamdashboard-MyDashboard.json",
"Triggers/",
"Triggers/trigger-MyTrigger.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the default fromversion of these items to 8.0.0 uploads only the external version of the files.

@thefrieddan1 thefrieddan1 merged commit d3ec197 into master May 15, 2024
28 checks passed
@thefrieddan1 thefrieddan1 deleted the ContentItemXSIAM-fromversion-is-now-8.0.0 branch May 15, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants