Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit] Ignore docker_native_image_config.json in simple repo #4314

Conversation

mmhw
Copy link
Contributor

@mmhw mmhw commented May 30, 2024

Description

Ignore docker_native_image_config.json in simple repo.
To avoid the following error:

FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/demisto-sdk/demisto-sdk/content/Tests/docker_native_image_config.json'

@mmhw mmhw requested a review from samuelFain as a code owner May 30, 2024 07:42
@mmhw mmhw self-assigned this May 30, 2024
Copy link

Changelog(s) in markdown:

  • Fixed an issue where the pre-commit command would fail on simple repository of the missing docker_native_image_config.json file. #4314

@mmhw mmhw requested a review from JudahSchwartz May 30, 2024 08:26
Copy link
Contributor

@JudahSchwartz JudahSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesnt seem like the right solution to me. We shouldnt distinguish based on internal vs external repo. If an external repo wants to run on the native image they should be allowed to. Lets instead lazy load this tag, that we should only need it if native image is declated in the precommit file

.github/workflows/on-push.yml Outdated Show resolved Hide resolved
@mmhw
Copy link
Contributor Author

mmhw commented Jun 2, 2024

doesnt seem like the right solution to me. We shouldnt distinguish based on internal vs external repo. If an external repo wants to run on the native image they should be allowed to. Lets instead lazy load this tag, that we should only need it if native image is declated in the precommit file

@JudahSchwartz I have made the change, if you could please look again.

@mmhw mmhw requested a review from JudahSchwartz June 3, 2024 08:00
Copy link
Contributor

@JudahSchwartz JudahSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

@mmhw mmhw merged commit 586a5ff into master Jun 5, 2024
25 checks passed
@mmhw mmhw deleted the MW/pre-commit/Ignore_docker_native_image_config.json_in_simple_repo branch June 5, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants