Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IN124 from Old validate #4317

Merged
merged 5 commits into from
Jun 2, 2024
Merged

Remove IN124 from Old validate #4317

merged 5 commits into from
Jun 2, 2024

Conversation

YuvHayun
Copy link
Contributor

@YuvHayun YuvHayun commented Jun 2, 2024 •
edited

Related Issues

fixes: CIAC-10734

Description

  • Remove IN124 from old validate.
  • Prevent IN124 from running with -a
  • Prevent IN124 from being ignorable.

@YuvHayun YuvHayun requested a review from idovandijk as a code owner June 2, 2024 10:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

Changelog(s) in markdown:

  • Removed support for IN124 - 'is param valid is hidden' validation from old-validate flow and prevent the validation from being ignored. #4317

JudahSchwartz
JudahSchwartz approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@JudahSchwartz JudahSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💣

.changelog/4317.yml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

Changelog(s) in markdown:

  • Removed support for IN124 - 'is param valid is hidden' validation from old-validate flow and prevent the validation from being ignored. The validation and the related information can be found in the new-validate flow. #4317

@YuvHayun YuvHayun merged commit 3263d17 into master Jun 2, 2024
25 checks passed
@YuvHayun YuvHayun deleted the remove_IN_124_from_validate_all_and_make_it_not_ignorable branch June 2, 2024 13:41
@content-bot content-bot mentioned this pull request Jun 18, 2024
Open
@samuelFain samuelFain mentioned this pull request Jun 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JudahSchwartz JudahSchwartz JudahSchwartz approved these changes

@idovandijk idovandijk Awaiting requested review from idovandijk idovandijk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@YuvHayun @JudahSchwartz