Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation rm101 in the new format #4322

Merged
merged 12 commits into from
Jun 6, 2024
Merged

Conversation

yedidyacohenpalo
Copy link
Contributor

Related Issues

fixes:

Description

Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, see my comments.
Also, make sure to fix the tests, add changelog, and add the error-code to the config file.

Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, minor comment.
@jbabazadeh approved from my side.

Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@jbabazadeh jbabazadeh self-assigned this Jun 5, 2024
@yedidyacohenpalo yedidyacohenpalo merged commit 4e131a3 into master Jun 6, 2024
24 of 25 checks passed
@yedidyacohenpalo yedidyacohenpalo deleted the validetion/RM101 branch June 6, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants