-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validation rm101 in the new format #4322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, see my comments.
Also, make sure to fix the tests, add changelog, and add the error-code to the config file.
demisto_sdk/commands/validate/validators/RM_validators/RM101_is_image_path_valid.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/RM_validators/RM101_is_image_path_valid.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/RM_validators/RM101_is_image_path_valid.py
Outdated
Show resolved
Hide resolved
…o validetion/RM101
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, minor comment.
@jbabazadeh approved from my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Related Issues
fixes:
Description