Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test-pre-commit-command validate use only BA100 validation #4336

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changelog/4336.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
changes:
- description: Changed test-pre-commit-command validate hook to run only BA100 validation.
type: internal
- description: demist-sdk lint command is deprecated and should be fully removed from the SDK on September 1st. Please use the pre-commit command instead.
type: breaking
pr_number: 4336
4 changes: 2 additions & 2 deletions .github/workflows/on-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ jobs:
run: |
# Run only a specific validation to make sure validate is triggered successfully in demisto-sdk pre-commit
cd content
echo -e "[validate]\nrun_specific_validations=BA101" > .demisto-sdk-conf
echo -e '[use_git]\nselect = ["BA100"]\n[path_based_validations]\nselect = ["BA100"]' > validation_config.toml

- name: run pre-commit on changed files
timeout-minutes: 60
Expand Down Expand Up @@ -284,7 +284,7 @@ jobs:
cd content
rm -rf .pre-commit-config_template.yaml
rm -f Tests/docker_native_image_config.json
demisto-sdk pre-commit --validate --show-diff-on-failure --verbose --mode=ci
demisto-sdk pre-commit --validate --show-diff-on-failure --verbose

- name: Upload artifacts
if: always()
Expand Down