Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template sentence in readme validations refactor #4373

Merged
merged 12 commits into from
Jun 24, 2024

Conversation

ilaredo
Copy link
Contributor

@ilaredo ilaredo commented Jun 20, 2024

Description

Moved RM107 to new validate

Copy link

Changelog(s) in markdown:

  • Added RM107 to the new validation format. The validation checks if given readme is consist %%FILL HERE%% substring or not. #4373

Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
Minor comments.

.changelog/4373.yml Outdated Show resolved Hide resolved
),
],
False,
2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why all this spaces?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

automatically

ilaredo and others added 3 commits June 23, 2024 17:59
Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
…s_template_sentence_in_readme.py

Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
…s_template_sentence_in_readme.py

Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

@ilaredo ilaredo merged commit 8052358 into master Jun 24, 2024
25 checks passed
@ilaredo ilaredo deleted the template-sentence-in-readme-validations-refactor branch June 24, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants