New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth-utils: add support in the native image #19619
auth-utils: add support in the native image #19619
Conversation
…IAC-861/update_native_image_with_auth_utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samuelFain @GuyAfik looks like a hard lock. We good with this?
Otherwise looks good to me
docker/py3-native/pyproject.toml
Outdated
@@ -69,6 +69,9 @@ python-whois = "*" | |||
ipwhois = "*" | |||
edgegrid-python = "*" | |||
tldextract = "*" | |||
pydantic = "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would lock to > version 2. Better to make sure in case something else gets added that it wont suddenly get switched
please also add to changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilappe great work!
- You can add the validations in the
verify.py
for theauth-utils
in theverify.py
of auth-utils image and then just add a symlink to it. - can we avoid locking the entire py3-native? it contains tons of packages which are getting updated, is it possible to update the dependancies only required for the new packages?
- as @JudahSchwartz mentioned, please add it to the changelog
Docker Image Ready - DevDocker automatic build at CircleCI has deployed your docker image: devdemisto/py3-native:8.3.0.73082
Docker Metadata
|
Docker Image Ready - DevDocker automatic build at CircleCI has deployed your docker image: devdemisto/py3-native:8.3.0.73085
Docker Metadata
|
Docker Image Ready - DevDocker automatic build at CircleCI has deployed your docker image: devdemisto/py3-native:8.4.0.74549
Docker Metadata
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, please wait for @JudahSchwartz 's approval
just left is my comment regarding pydantic, otherwise lgtm |
…IAC-861/update_native_image_with_auth_utils
Docker Image Ready - DevDocker automatic build at CircleCI has deployed your docker image: devdemisto/py3-native:8.4.0.74724
Docker Metadata
|
Docker Image Ready - ProductionDocker automatic build at CircleCI has deployed your docker image: demisto/py3-native:8.4.0.74970
Docker Metadata
|
Related Content Pull Request
Related PR: link to the PR at demisto/content
Related Issues
Related: https://jira-hq.paloaltonetworks.local/browse/CIAC-861
Related PRs
Related: #19547
Description
after the new image
auth-utils
will be merged in this PRthis PR will update the native image to support the new
auth-utils
image