Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth-utils: add support in the native image #19619

Merged
merged 16 commits into from Sep 20, 2023

Conversation

ilappe
Copy link
Contributor

@ilappe ilappe commented Aug 30, 2023

Related Content Pull Request

Related PR: link to the PR at demisto/content

Related Issues

Related: https://jira-hq.paloaltonetworks.local/browse/CIAC-861

Related PRs

Related: #19547

Description

after the new image auth-utils will be merged in this PR
this PR will update the native image to support the new auth-utils image

@ilappe ilappe self-assigned this Aug 30, 2023
Copy link
Collaborator

@JudahSchwartz JudahSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelFain @GuyAfik looks like a hard lock. We good with this?
Otherwise looks good to me

@@ -69,6 +69,9 @@ python-whois = "*"
ipwhois = "*"
edgegrid-python = "*"
tldextract = "*"
pydantic = "*"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would lock to > version 2. Better to make sure in case something else gets added that it wont suddenly get switched

@JudahSchwartz
Copy link
Collaborator

please also add to changelog

Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilappe great work!

  1. You can add the validations in the verify.py for the auth-utils in the verify.py of auth-utils image and then just add a symlink to it.
  2. can we avoid locking the entire py3-native? it contains tons of packages which are getting updated, is it possible to update the dependancies only required for the new packages?
  3. as @JudahSchwartz mentioned, please add it to the changelog

docker/py3-native/Dockerfile Show resolved Hide resolved
docker/py3-native/verify.py Outdated Show resolved Hide resolved
@xsoar-bot
Copy link

Docker Image Ready - Dev

Docker automatic build at CircleCI has deployed your docker image: devdemisto/py3-native:8.3.0.73082
It is available now on docker hub at: https://hub.docker.com/r/devdemisto/py3-native/tags
Get started by pulling the image:

docker pull devdemisto/py3-native:8.3.0.73082

Docker Metadata

  • Image Size: 1187.31 MB
  • Image ID: sha256:3f791ba040017a3ac1562dc93bebc87b8a2bb71cfafbb6a2dd1116c39f42adca
  • Created: 2023-09-06T10:48:43.917564403Z
  • Arch: linux/amd64
  • Command: ["python3"]
  • Environment:
    • PATH=/usr/local/bin:/home/python/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
    • container=oci
    • PYTHON_VERSION=3.10.8
    • LANG=C.UTF-8
    • DOCKER_IMAGE=devdemisto/py3-native:8.3.0.73082
    • NLTK_DATA=/ml/nltk_data
  • Labels:
    • architecture:x86_64
    • build-date:2023-08-23T05:46:27
    • com.redhat.component:ubi9-container
    • com.redhat.license_terms:https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI
    • description:The Universal Base Image is designed and engineered to be the base layer for all of your containerized applications, middleware and utilities. This base image is freely redistributable, but Red Hat only supports Red Hat technologies through subscriptions for Red Hat products. This image is maintained by Red Hat and updated regularly.
    • distribution-scope:public
    • io.buildah.version:1.29.0
    • io.k8s.description:The Universal Base Image is designed and engineered to be the base layer for all of your containerized applications, middleware and utilities. This base image is freely redistributable, but Red Hat only supports Red Hat technologies through subscriptions for Red Hat products. This image is maintained by Red Hat and updated regularly.
    • io.k8s.display-name:Red Hat Universal Base Image 9
    • io.openshift.expose-services:
    • io.openshift.tags:base rhel9
    • maintainer:Red Hat, Inc.
    • name:ubi9
    • org.opencontainers.image.authors:Demisto <containers@demisto.com>
    • org.opencontainers.image.revision:407dd7ff124d57d4f3cf9e21140665270648f511
    • org.opencontainers.image.version:8.3.0.73082
    • release:722.1692769367
    • summary:Provides the latest release of Red Hat Universal Base Image 9.
    • url:https://access.redhat.com/containers/#/registry.access.redhat.com/ubi9/images/9.2-722.1692769367
    • vcs-ref:6b5892a11894993e819f9a93ee1d7aaa80dc3a17
    • vcs-type:git
    • vendor:Red Hat, Inc.
    • version:9.2

@xsoar-bot
Copy link

Docker Image Ready - Dev

Docker automatic build at CircleCI has deployed your docker image: devdemisto/py3-native:8.3.0.73085
It is available now on docker hub at: https://hub.docker.com/r/devdemisto/py3-native/tags
Get started by pulling the image:

docker pull devdemisto/py3-native:8.3.0.73085

Docker Metadata

  • Image Size: 1189.59 MB
  • Image ID: sha256:378470b0b20c913c8e004e6927d4a80714045e81f9e69b9c808d524f9e3c0d46
  • Created: 2023-09-06T13:54:26.83859327Z
  • Arch: linux/amd64
  • Command: ["python3"]
  • Environment:
    • PATH=/usr/local/bin:/home/python/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
    • container=oci
    • PYTHON_VERSION=3.10.8
    • LANG=C.UTF-8
    • DOCKER_IMAGE=devdemisto/py3-native:8.3.0.73085
    • NLTK_DATA=/ml/nltk_data
  • Labels:
    • architecture:x86_64
    • build-date:2023-08-23T05:46:27
    • com.redhat.component:ubi9-container
    • com.redhat.license_terms:https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI
    • description:The Universal Base Image is designed and engineered to be the base layer for all of your containerized applications, middleware and utilities. This base image is freely redistributable, but Red Hat only supports Red Hat technologies through subscriptions for Red Hat products. This image is maintained by Red Hat and updated regularly.
    • distribution-scope:public
    • io.buildah.version:1.29.0
    • io.k8s.description:The Universal Base Image is designed and engineered to be the base layer for all of your containerized applications, middleware and utilities. This base image is freely redistributable, but Red Hat only supports Red Hat technologies through subscriptions for Red Hat products. This image is maintained by Red Hat and updated regularly.
    • io.k8s.display-name:Red Hat Universal Base Image 9
    • io.openshift.expose-services:
    • io.openshift.tags:base rhel9
    • maintainer:Red Hat, Inc.
    • name:ubi9
    • org.opencontainers.image.authors:Demisto <containers@demisto.com>
    • org.opencontainers.image.revision:8c508467806beb1b29c8ecadb06428811b1f8358
    • org.opencontainers.image.version:8.3.0.73085
    • release:722.1692769367
    • summary:Provides the latest release of Red Hat Universal Base Image 9.
    • url:https://access.redhat.com/containers/#/registry.access.redhat.com/ubi9/images/9.2-722.1692769367
    • vcs-ref:6b5892a11894993e819f9a93ee1d7aaa80dc3a17
    • vcs-type:git
    • vendor:Red Hat, Inc.
    • version:9.2

@xsoar-bot
Copy link

Docker Image Ready - Dev

Docker automatic build at CircleCI has deployed your docker image: devdemisto/py3-native:8.4.0.74549
It is available now on docker hub at: https://hub.docker.com/r/devdemisto/py3-native/tags
Get started by pulling the image:

docker pull devdemisto/py3-native:8.4.0.74549

Docker Metadata

  • Image Size: 1209.37 MB
  • Image ID: sha256:2c4339e6e1cd89cd280562d9317f9f3cbc81e3878511a7e071d403a646f7a769
  • Created: 2023-09-19T14:20:52.219921311Z
  • Arch: linux/amd64
  • Command: ["python3"]
  • Environment:
    • PATH=/usr/local/bin:/home/python/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
    • container=oci
    • PYTHON_VERSION=3.10.8
    • LANG=C.UTF-8
    • DOCKER_IMAGE=devdemisto/py3-native:8.4.0.74549
    • NLTK_DATA=/ml/nltk_data
  • Labels:
    • architecture:x86_64
    • build-date:2023-08-23T05:46:27
    • com.redhat.component:ubi9-container
    • com.redhat.license_terms:https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI
    • description:The Universal Base Image is designed and engineered to be the base layer for all of your containerized applications, middleware and utilities. This base image is freely redistributable, but Red Hat only supports Red Hat technologies through subscriptions for Red Hat products. This image is maintained by Red Hat and updated regularly.
    • distribution-scope:public
    • io.buildah.version:1.29.0
    • io.k8s.description:The Universal Base Image is designed and engineered to be the base layer for all of your containerized applications, middleware and utilities. This base image is freely redistributable, but Red Hat only supports Red Hat technologies through subscriptions for Red Hat products. This image is maintained by Red Hat and updated regularly.
    • io.k8s.display-name:Red Hat Universal Base Image 9
    • io.openshift.expose-services:
    • io.openshift.tags:base rhel9
    • maintainer:Red Hat, Inc.
    • name:ubi9
    • org.opencontainers.image.authors:Demisto <containers@demisto.com>
    • org.opencontainers.image.revision:84b28a8ecba1a1e90de5b3a41b307fac82b9b7af
    • org.opencontainers.image.version:8.4.0.74549
    • release:722.1692769367
    • summary:Provides the latest release of Red Hat Universal Base Image 9.
    • url:https://access.redhat.com/containers/#/registry.access.redhat.com/ubi9/images/9.2-722.1692769367
    • vcs-ref:6b5892a11894993e819f9a93ee1d7aaa80dc3a17
    • vcs-type:git
    • vendor:Red Hat, Inc.
    • version:9.2

Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, please wait for @JudahSchwartz 's approval

@JudahSchwartz
Copy link
Collaborator

just left is my comment regarding pydantic, otherwise lgtm

@xsoar-bot
Copy link

Docker Image Ready - Dev

Docker automatic build at CircleCI has deployed your docker image: devdemisto/py3-native:8.4.0.74724
It is available now on docker hub at: https://hub.docker.com/r/devdemisto/py3-native/tags
Get started by pulling the image:

docker pull devdemisto/py3-native:8.4.0.74724

Docker Metadata

  • Image Size: 1209.67 MB
  • Image ID: sha256:3dbab5bf0e5faed9948a2bb85bdf999a5f7b494f09862cb575fa4638339f602b
  • Created: 2023-09-20T07:38:37.922113253Z
  • Arch: linux/amd64
  • Command: ["python3"]
  • Environment:
    • PATH=/usr/local/bin:/home/python/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
    • container=oci
    • PYTHON_VERSION=3.10.8
    • LANG=C.UTF-8
    • DOCKER_IMAGE=devdemisto/py3-native:8.4.0.74724
    • NLTK_DATA=/ml/nltk_data
  • Labels:
    • architecture:x86_64
    • build-date:2023-08-23T05:46:27
    • com.redhat.component:ubi9-container
    • com.redhat.license_terms:https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI
    • description:The Universal Base Image is designed and engineered to be the base layer for all of your containerized applications, middleware and utilities. This base image is freely redistributable, but Red Hat only supports Red Hat technologies through subscriptions for Red Hat products. This image is maintained by Red Hat and updated regularly.
    • distribution-scope:public
    • io.buildah.version:1.29.0
    • io.k8s.description:The Universal Base Image is designed and engineered to be the base layer for all of your containerized applications, middleware and utilities. This base image is freely redistributable, but Red Hat only supports Red Hat technologies through subscriptions for Red Hat products. This image is maintained by Red Hat and updated regularly.
    • io.k8s.display-name:Red Hat Universal Base Image 9
    • io.openshift.expose-services:
    • io.openshift.tags:base rhel9
    • maintainer:Red Hat, Inc.
    • name:ubi9
    • org.opencontainers.image.authors:Demisto <containers@demisto.com>
    • org.opencontainers.image.revision:be7c59171bc0209b2397e4a3dff6855ed9f32da8
    • org.opencontainers.image.version:8.4.0.74724
    • release:722.1692769367
    • summary:Provides the latest release of Red Hat Universal Base Image 9.
    • url:https://access.redhat.com/containers/#/registry.access.redhat.com/ubi9/images/9.2-722.1692769367
    • vcs-ref:6b5892a11894993e819f9a93ee1d7aaa80dc3a17
    • vcs-type:git
    • vendor:Red Hat, Inc.
    • version:9.2

@ilappe ilappe merged commit 8b8e8f1 into master Sep 20, 2023
6 of 7 checks passed
@ilappe ilappe deleted the ilappe/CIAC-861/update_native_image_with_auth_utils branch September 20, 2023 09:23
@xsoar-bot
Copy link

Docker Image Ready - Production

Docker automatic build at CircleCI has deployed your docker image: demisto/py3-native:8.4.0.74970
It is available now on docker hub at: https://hub.docker.com/r/demisto/py3-native/tags
Get started by pulling the image:

docker pull demisto/py3-native:8.4.0.74970

Docker Metadata

  • Image Size: 1209.85 MB
  • Image ID: sha256:570b147e001c2bc966b76b8b3ba4abfbce53e9e586fd36fbef347c20207e4a73
  • Created: 2023-09-20T09:39:56.285188478Z
  • Arch: linux/amd64
  • Command: ["python3"]
  • Environment:
    • PATH=/usr/local/bin:/home/python/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
    • container=oci
    • PYTHON_VERSION=3.10.8
    • LANG=C.UTF-8
    • DOCKER_IMAGE=demisto/py3-native:8.4.0.74970
    • NLTK_DATA=/ml/nltk_data
  • Labels:
    • architecture:x86_64
    • build-date:2023-08-23T05:46:27
    • com.redhat.component:ubi9-container
    • com.redhat.license_terms:https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI
    • description:The Universal Base Image is designed and engineered to be the base layer for all of your containerized applications, middleware and utilities. This base image is freely redistributable, but Red Hat only supports Red Hat technologies through subscriptions for Red Hat products. This image is maintained by Red Hat and updated regularly.
    • distribution-scope:public
    • io.buildah.version:1.29.0
    • io.k8s.description:The Universal Base Image is designed and engineered to be the base layer for all of your containerized applications, middleware and utilities. This base image is freely redistributable, but Red Hat only supports Red Hat technologies through subscriptions for Red Hat products. This image is maintained by Red Hat and updated regularly.
    • io.k8s.display-name:Red Hat Universal Base Image 9
    • io.openshift.expose-services:
    • io.openshift.tags:base rhel9
    • maintainer:Red Hat, Inc.
    • name:ubi9
    • org.opencontainers.image.authors:Demisto <containers@demisto.com>
    • org.opencontainers.image.revision:8b8e8f1de91fccf14ffeeba105af486b5176ae63
    • org.opencontainers.image.version:8.4.0.74970
    • release:722.1692769367
    • summary:Provides the latest release of Red Hat Universal Base Image 9.
    • url:https://access.redhat.com/containers/#/registry.access.redhat.com/ubi9/images/9.2-722.1692769367
    • vcs-ref:6b5892a11894993e819f9a93ee1d7aaa80dc3a17
    • vcs-type:git
    • vendor:Red Hat, Inc.
    • version:9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants