Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domaintools #19710

Closed
wants to merge 9 commits into from
Closed

Domaintools #19710

wants to merge 9 commits into from

Conversation

wesleya
Copy link

@wesleya wesleya commented Sep 5, 2023

Status

Ready

Related Content Pull Request

Related PR: demisto/content#29474

Related Issues

N/A

Description

Add a new image for use in new version 2.0 PR of the DomainTools Iris Pack

@wesleya
Copy link
Author

wesleya commented Sep 5, 2023

Do you have a recommendation for fixing the failed ci step? The error sounds like it has something to do with the version of python we are using 3.10.13? But this is the default the came when we started the image using the ./docker/create_new_docker_image.py -p three --pkg domaintools-api domaintools command. This image also seems to work fine when we build for local testing. I've tried a few changes with no luck so far, any guidance is appreciated, thank you!

@JudahSchwartz
Copy link
Collaborator

@wesleya seems like this error is being caused by having "3.10.13" in the pipfile, but it isnt installed on the system. Then the prompt asking to download the version is ignored, this is a bug and we'll fix it soon
I think setting the version to "3.10" in the pipfile and relocking should do the trick

@RotemAmit RotemAmit requested review from MichaelYochpaz and removed request for RotemAmit September 7, 2023 07:57
@RotemAmit RotemAmit assigned MichaelYochpaz and unassigned RotemAmit Sep 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Docker Image Ready - Dev

Docker automatic build at CircleCI has completed. The docker image is available as an artifact of the build.

Follow the output from the build on how to load the image locally for testing:

@wesleya
Copy link
Author

wesleya commented Sep 8, 2023

thank you for the guidance there @JudahSchwartz, I believe we've made the necessary update. Lmk if there's anything else needed, thank you

@MichaelYochpaz
Copy link

@wesleya We're working on creating a Docker image containing multiple lightweight SDK packages of different vendors (instead of unnecessarily creating a separate Docker image for each one).
We've added your package (domaintools-api) there.

Once it's merged and the Docker image is available, I'll close this PR (keeping it open for now in case we will unexpectedly need it) and give you an update.

@wesleya
Copy link
Author

wesleya commented Sep 11, 2023

@MichaelYochpaz that all sounds great, I'll keep an eye out for when for when that image is available. Thank you for the update.

@MichaelYochpaz
Copy link

@MichaelYochpaz that all sounds great, I'll keep an eye out for when for when that image is available. Thank you for the update.

@wesleya It was actually already merged yesterday shortly after I sent the message, you can see the new Docker image here.

Could you please confirm that this Docker image works fine with your pack's integrations & scripts, and update your other Content PR with this Docker if it does? Please let me know if it does and I'll close this PR.

Feel free to also message me on the DFIR Slack if you've got any questions / need help.

@wesleya
Copy link
Author

wesleya commented Sep 11, 2023

@MichaelYochpaz ah yes I see it. The demisto/vendors-sdk image seems to work as expected with our app. I've updated the content PR with this image, feel free to close this PR. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants