Trend pytmv1 0.6.1

[shaqnawe]

Status

In Progress.

Related Content Pull Request

demisto/content#30157

Related Issues

Related: link to the issue

Description

Created new demisto-docker image with custom pytmv1 package.

[github-actions]

Docker Image Ready - Dev

Docker automatic build at CircleCI has completed. The docker image is available as an artifact of the build.

Follow the output from the build on how to load the image locally for testing:

[JudahSchwartz]

do we need to lock on this specifc version? If yes we should lock in the dependabot config also by telling dependabot to ignore it.
You can find other examples in .github/dependabot.yml

[JudahSchwartz]

would reccomend locking on * and using dynamic versioning to express the version in the tag instead of putting the version in the name of the image

[ilappe]

@JudahSchwartz
i recommend to add the module pytmv1 to the our new image vendors-sdk
instead of new image, as this is small module
WDYT?

[ilappe]

Hi @shaqnawe
i will add the module pytmv1 to the dependencies list in the image vendors-sdk
in docker/vendors-sdk/pyproject.toml
so i close this PR

[ilappe]

due to dependencies collision the pytmv1 failed to be added to the vendors-sdk
@JudahSchwartz do we have something to do to fix it or we will need the new docker image for this module?

[shaqnawe]

Hi @shaqnawe i will add the module pytmv1 to the dependencies list in the image vendors-sdk in docker/vendors-sdk/pyproject.toml so i close this PR

@ilappe Is there something I need to do on this?

[kgal-pan]

Looks like we have some hard-coded requests versions used by pytmv1 and pycti. Since pycti is locked because of #19991, I think the fastest way forward is to create a new image specifically for pytmv1 in this PR.

@shaqnawe - Can you please add a verify.py script to fix https://github.com/demisto/dockerfiles/actions/runs/6502596031/job/17714329333?pr=20932? See https://github.com/demisto/dockerfiles?tab=readme-ov-file#adding-a-verifypy-script for instructions.

[ilappe]

Hi @shaqnawe i will add the module pytmv1 to the dependencies list in the image vendors-sdk in docker/vendors-sdk/pyproject.toml so i close this PR

@ilappe Is there something I need to do on this?

Hi @shaqnawe
as mentioned above - we have issue to add pytmv1 to an existing image so we will need to create a separate image for that
please follow the comments above

• Trend pytmv1 0.6.1 #20932 (comment)
• Trend pytmv1 0.6.1 #20932 (comment)
• Trend pytmv1 0.6.1 #20932 (comment)
  thanks!

[shaqnawe]

@ilappe Please let me know if this is correct, thank you.

[kgal-pan]

@shaqnawe - In continuation of #20932 (comment), can you please rename the folder to docker/pytmv1 (remove -061 from the name):

mv docker/pytmv1-061 docker/pytmv1

[ilappe]

@shaqnawe - thanks!
can you release the lock of pytmv1 = "==0.6.1" in the Pipfile as mentioned in this comment?

[ilappe]

Great!

[shaqnawe]

@ilappe There is a new update for pytmv1. Do I need to update the image and push or will that be automatically done?

[ilappe]

@ilappe There is a new update for pytmv1. Do I need to update the image and push or will that be automatically done?

@shaqnawe - we will update it
@kgal-pan
can you do re-lock to take the newer version mentioned?

[kgal-pan]

@kgal-pan can you do re-lock to take the newer version mentioned?

47e1f4d

[ilappe]

will be merged via #21608