S/MIME files without to/from/subject fields #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michal-dagan
changed the title
5 tasks
bziser
approved these changes
Jul 25, 2023
|
@michal-dagan Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Related PR: link to the PR at demisto/content
Related PR: link to the PR at demisto//dockerfiles
Description
If an email is of type 'multipart/signed' but does not have the 'to', 'from', or 'subject' fields, it will not enter the if condition to save the 'AttachmentsData' in the 'email_data' variable. As a result, when using the 'ParseEmailFilesV2' script and the attachments will not be saved to the war-room because they were not included in the 'AttachmentsData' field.
Screenshots
Paste here any images that will help the reviewer
Must have