Linter for Issue #53, #56.

demmings · Mar 21, 2024 · 5519faa · 5519faa
1 parent c2ed7a7
commit 5519faa
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/dist/gssql.js b/dist/gssql.js
@@ -1315,7 +1315,7 @@ class Table {       //  skipcq: JS-0128
         this.tableData = TableData.loadTableData(namedRange, cacheSeconds);
 
         if (!this.hasColumnTitle) {
-            this.addColumnLetters(this.tableData);
+            Table.addColumnLetters(this.tableData);
         }
 
         Logger.log(`Load Data: Range=${namedRange}. Items=${this.tableData.length}`);
@@ -1334,7 +1334,7 @@ class Table {       //  skipcq: JS-0128
             return this;
 
         if (!this.hasColumnTitle) {
-            this.addColumnLetters(tableData);
+            Table.addColumnLetters(tableData);
         }
 
         this.tableData = Table.removeEmptyRecordsAtEndOfTable(tableData);
@@ -1366,7 +1366,7 @@ class Table {       //  skipcq: JS-0128
      * @param {any[][]} tableData - table data that does not currently contain a first row with column names.
      * @returns {any[][]} - updated table data that includes a column title row.
      */
-    addColumnLetters(tableData) {
+    static addColumnLetters(tableData) {
         if (tableData.length === 0)
             return [[]];
 
@@ -4020,8 +4020,8 @@ class ConglomerateRecord {
 
         const aggTableColumnNames = aggTable.tableData[0];
         for (let i = 0; i < aggTableColumnNames.length; i++) {
-            let oldName = SelectTables.toUpperCaseExceptQuoted(virtualFields[i].columnName, true);
-            let newName = aggTableColumnNames[i];
+            const oldName = SelectTables.toUpperCaseExceptQuoted(virtualFields[i].columnName, true);
+            const newName = aggTableColumnNames[i];
             mappedField.push({ oldName, newName });    
         }
 
@@ -4047,7 +4047,7 @@ class ConglomerateRecord {
      * @param {Object[]} mappedField 
      */
     static replaceFieldNames(calcFunc, mappedField) {
-        for (let item of mappedField) {
+        for (const item of mappedField) {
             calcFunc = calcFunc.replaceAll(item.oldName, item.newName);
         }
 

diff --git a/src/Table.js b/src/Table.js
@@ -74,7 +74,7 @@ class Table {       //  skipcq: JS-0128
         this.tableData = TableData.loadTableData(namedRange, cacheSeconds);
 
         if (!this.hasColumnTitle) {
-            this.addColumnLetters(this.tableData);
+            Table.addColumnLetters(this.tableData);
         }
 
         Logger.log(`Load Data: Range=${namedRange}. Items=${this.tableData.length}`);
@@ -93,7 +93,7 @@ class Table {       //  skipcq: JS-0128
             return this;
 
         if (!this.hasColumnTitle) {
-            this.addColumnLetters(tableData);
+            Table.addColumnLetters(tableData);
         }
 
         this.tableData = Table.removeEmptyRecordsAtEndOfTable(tableData);
@@ -125,7 +125,7 @@ class Table {       //  skipcq: JS-0128
      * @param {any[][]} tableData - table data that does not currently contain a first row with column names.
      * @returns {any[][]} - updated table data that includes a column title row.
      */
-    addColumnLetters(tableData) {
+    static addColumnLetters(tableData) {
         if (tableData.length === 0)
             return [[]];
 

diff --git a/src/Views.js b/src/Views.js
@@ -2249,8 +2249,8 @@ class ConglomerateRecord {
 
         const aggTableColumnNames = aggTable.tableData[0];
         for (let i = 0; i < aggTableColumnNames.length; i++) {
-            let oldName = SelectTables.toUpperCaseExceptQuoted(virtualFields[i].columnName, true);
-            let newName = aggTableColumnNames[i];
+            const oldName = SelectTables.toUpperCaseExceptQuoted(virtualFields[i].columnName, true);
+            const newName = aggTableColumnNames[i];
             mappedField.push({ oldName, newName });    
         }
 
@@ -2276,7 +2276,7 @@ class ConglomerateRecord {
      * @param {Object[]} mappedField 
      */
     static replaceFieldNames(calcFunc, mappedField) {
-        for (let item of mappedField) {
+        for (const item of mappedField) {
             calcFunc = calcFunc.replaceAll(item.oldName, item.newName);
         }