initial commit hw metrics queue #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 91.54% 91.56% +0.01%
==========================================
Files 114 114
Lines 9112 9136 +24
==========================================
+ Hits 8342 8365 +23
- Misses 770 771 +1
|
thorrester
reviewed
May 16, 2024
| # report | ||
| logger.info("Got metrics: {}", metrics_unit.model_dump()) | ||
|
|
||
| except Empty: |
There was a problem hiding this comment.
adding an exception with timeout so we don't block the thread indefinitely
thorrester
reviewed
May 16, 2024
| @@ -133,8 +171,11 @@ def _log_hardware_metrics(self, interval: int) -> None: | |||
| assert self.active_run is not None, "active_run should not be None" | |||
|
|
|||
| # run hardware logger in background thread | |||
| executor = concurrent.futures.ThreadPoolExecutor(max_workers=1) | |||
| executor.submit(run_hardware_logger, interval, self.active_run) | |||
| queue: Queue[HardwareMetrics] = Queue() | |||
There was a problem hiding this comment.
Realized we can assign queue without adding it to the active run or run_manager
thorrester
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Short Summary
This second part of hw metrics contains the code to pull hw metrics and send them to a global background queue, where they are then picked up by a consumer function to be sent to the db in the third part.
Context
Continuation of getting hw metrics into opsml.