dockerfile-testt #20
dockerfile-testt #20
Conversation
![demoargon[bot]](https://avatars.githubusercontent.com/u/74548729?s=60&v=4){kind=small}
| COPY .npmrc package.json package-lock.json lerna.json ./ | ||
|
|
||
| # Install git, which is necessary for the install process. | ||
| RUN apt-get update && \ |
There was a problem hiding this comment.
Finding of type dockerfiles detected.
APT-GET Missing '-y' To Avoid Manual Input
Check if apt-get calls use the flag -y to avoid user manual input.
| COPY .npmrc package.json package-lock.json lerna.json ./ | ||
|
|
||
| # Install git, which is necessary for the install process. | ||
| RUN apt-get update && \ |
There was a problem hiding this comment.
Finding of type dockerfiles detected.
Apt Get Install Pin Version Not Defined
When installing a package, its pin version should be defined
|
|
||
|
|
||
| # Start from the official Node 6 alpine image. https://hub.docker.com/_/node/ | ||
| FROM node:8 |
There was a problem hiding this comment.
Finding of type dockerfiles detected.
Healthcheck Instruction Missing
Ensure that HEALTHCHECK is being used. The HEALTHCHECK instruction tells Docker how to test a container to check that it is still working
| COPY .npmrc package.json package-lock.json lerna.json ./ | ||
|
|
||
| # Install git, which is necessary for the install process. | ||
| RUN apt-get update && \ |
There was a problem hiding this comment.
Finding of type dockerfiles detected.
APT-GET Not Avoiding Additional Packages
Check if any apt-get installs don't use '--no-install-recommends' flag to avoid installing additional packages.
| COPY .npmrc package.json package-lock.json lerna.json ./ | ||
|
|
||
| # Install git, which is necessary for the install process. | ||
| RUN apt-get update && \ |
There was a problem hiding this comment.
Finding of type dockerfiles detected.
Apt Get Install Lists Were Not Deleted
After using apt-get install, it is needed to delete apt-get lists
No description provided.