This repository has been archived by the owner on Nov 11, 2019. It is now read-only.
[ui] simple change to remove warning about breadcrumbs #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gws
reviewed
May 14, 2019
There was a problem hiding this comment.
Hmm, this will fix the warning, but since the standard HTML href kills programmatic nav it may blow away app state that we wanted (thinking of this pattern applied to the audit definition flow, for instance). Others have wanted a fix for this in Blueprint too, but another option might be to use history.pushState from react-router-dom in an onClick attribute if this causes problems anywhere in the application.
|
Interesting. Well, it looks like we are safe from that concern here, but I will definitely keep that in mind. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.