Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary functions like find and replace #5

Closed
fhightower opened this issue Jan 12, 2021 · 4 comments · Fixed by #6
Closed

Remove unnecessary functions like find and replace #5

fhightower opened this issue Jan 12, 2021 · 4 comments · Fixed by #6
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fhightower
Copy link
Contributor

There is no reason that I can see to keep these around as they are just wrappers around python's regex module.

@fhightower fhightower self-assigned this Jan 12, 2021
@fhightower fhightower added enhancement New feature or request good first issue Good for newcomers labels Jan 12, 2021
@ckmganesh
Copy link
Contributor

I would like to do this. Can you assign this to me

@fhightower fhightower assigned ckmganesh and unassigned fhightower Jan 16, 2021
@fhightower
Copy link
Contributor Author

fhightower commented Jan 16, 2021

@ckmganesh : Absolutely, thank you! If you have any questions, please do not hesitate to ask. As stated in the issue's title, the goal is to remove some of the simple functions from this library. I'd like to remove them because developers should just use the built-in re library. I think the following functions should be removed:

  • regex_escape
  • replace
  • find

If you think any of these ^ should not be removed or if you find any others you think should not be removed, let me know.

Thanks again! I'm excited to have some help on this project.

@ckmganesh
Copy link
Contributor

Yeah sure.

@fhightower
Copy link
Contributor Author

Perfect, thanks @ckmganesh !

fhightower added a commit that referenced this issue Jan 21, 2021
fhightower added a commit that referenced this issue Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants