New checkbox widget #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic checkbox widget. isChecked() function to see current state TODO: customization of size, location, colour, etc..
demonnic
reviewed
Jan 4, 2024
src/resources/checkbox.lua
Outdated
| height = 25, | ||
| color = "white", | ||
| downColor = "white", | ||
| downStyle = [[ background-color: white; border-image: url(/home/kirk/mudlet-data/profiles/Development/checkbox-25px.png); ]], |
There was a problem hiding this comment.
should use self.checkboxFile and self.uncheckedFile instead of hardcoding them
demonnic
reviewed
Jan 4, 2024
src/resources/checkbox.lua
Outdated
|
|
||
| function checkbox:createDisplay() | ||
|
|
||
| self:set_constraints({x = "30%", y = "60%", width = 200, height = 25}) |
There was a problem hiding this comment.
these should be set via the cons values in the checkbox:new function. We just then let inheritance handle the rest.
- add setChecked(boolean) function - remove set_constraints - remove hard coded file location - made initial checkbox table local
- set label name on initialization, - new echo() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic checkbox widget.
isChecked() function to see current state
TODO: customization of size, location, colour, etc..