Allow target blank in v-cleanhtml #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we allow the target attr, we have to make sure that the link is safe. Chromium seems to add `rel="noopener"` automatically as of v88, however to also ensure correct behavior for other engines, the `rel` attr is added whenever a target is set to "_blank".
salisdemos
approved these changes
Dec 16, 2022
salisdemos
reviewed
Dec 16, 2022
salisdemos
approved these changes
Dec 16, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we allow the target attr, we have to make sure that the link is safe. Chromium seems to add
rel="noopener"automatically as of v88, however to also ensure correct behavior for other engines, therelattr is added whenever a target is set to "_blank".See