Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compilation warning in Fable AsyncResult #92

Closed
landy opened this issue Jul 21, 2020 · 5 comments · Fixed by #93
Closed

compilation warning in Fable AsyncResult #92

landy opened this issue Jul 21, 2020 · 5 comments · Fixed by #93

Comments

@landy
Copy link

landy commented Jul 21, 2020

Hello, thank you for a great library.

I'm not really sure if this issue should be created here, in Fable repository or it is something I did wrong.

After I installed FsToolkit.ErrorHandling to my Safe stack project I started getting compilation error from Fable compiler:

WARNING in ./.fable/FsToolkit.ErrorHandling.1.4.0/AsyncResult.fs 52:13-22
"export 'awaitTask' was not found in '../fable-library.2.10.2/Async.js'

Any help would be appreciated

@TheAngryByrd
Copy link
Collaborator

Hmm “awaitTask“ shouldn’t be showing up. I might have a missed an IFDEF. I’ll investigate.

@TheAngryByrd
Copy link
Collaborator

Yeah looks like I need to IFDEF off https://github.com/demystifyfp/FsToolkit.ErrorHandling/blob/master/src/FsToolkit.ErrorHandling/AsyncResult.fs#L26-L36. What version of Fable are you running. We have tests and they're passing so this might be a recent change to Fable.

@landy
Copy link
Author

landy commented Jul 22, 2020

Im using
fable-compiler: 2.10.2
fable-loader: 2.1.9
Fable.Core: 3.1.5

@TheAngryByrd
Copy link
Collaborator

Ok, give the latest 1.4.3 a try.

@landy
Copy link
Author

landy commented Jul 24, 2020

It is ok now! thanks a lot for such a quick fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants