Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonicalize option type annotations #140

Merged
merged 2 commits into from Oct 19, 2021

Conversation

cmeeren
Copy link
Contributor

@cmeeren cmeeren commented Oct 19, 2021

This changes all Option<_> type annotations to the idiomatic _ option form.

I have long been annoyed at Option<_> Intellisense type hints across my solution when I use asyncOption. Suddenly realized I could probably do something about it fairly easily by creating a trivial PR. 馃槄

@TheAngryByrd
Copy link
Collaborator

This changes all Option<_> type annotations in AsyncOptionBuilder to the idiomatic _ option form.

Oh wow I didn't know about this. Thanks for bringing this up!


warning NU3028: Package 'Paket 6.0.0-beta8' from source 'https://api.nuget.org/v3/index.json': The repository primary signature's timestamp found a chain building issue: ExplicitDistrust: The trust setting for this policy was set to Deny.
error NU3037: Package 'Paket 6.0.0-beta8' from source 'https://api.nuget.org/v3/index.json': The repository primary signature validity period has expired.
warning NU3028: Package 'fake-cli 5.20.4-alpha.1642' from source 'https://api.nuget.org/v3/index.json': The repository primary signature's timestamp found a chain building issue: ExplicitDistrust: The trust setting for this policy was set to Deny.
error NU3037: Package 'fake-cli 5.20.4-alpha.1642' from source 'https://api.nuget.org/v3/index.json': The repository primary signature validity period has expired.

Package "fake-cli" failed to restore, due to Microsoft.DotNet.ToolPackage.ToolPackageException: The tool package could not be restored.
   at Microsoft.DotNet.Tools.Tool.Install.ProjectRestorer.Restore(FilePath project, PackageLocation packageLocation, String verbosity)
   at Microsoft.DotNet.ToolPackage.ToolPackageInstaller.InstallPackageToExternalManagedLocation(PackageLocation packageLocation, PackageId packageId, VersionRange versionRange, String targetFramework, String verbosity)
   at Microsoft.DotNet.Tools.Tool.Restore.ToolRestoreCommand.InstallPackages(ToolManifestPackage package, Nullable`1 configFile)
Package "paket" failed to restore, due to Microsoft.DotNet.ToolPackage.ToolPackageException: The tool package could not be restored.
   at Microsoft.DotNet.Tools.Tool.Install.ProjectRestorer.Restore(FilePath project, PackageLocation packageLocation, String verbosity)
   at Microsoft.DotNet.ToolPackage.ToolPackageInstaller.InstallPackageToExternalManagedLocation(PackageLocation packageLocation, PackageId packageId, VersionRange versionRange, String targetFramework, String verbosity)
   at Microsoft.DotNet.Tools.Tool.Restore.ToolRestoreCommand.InstallPackages(ToolManifestPackage package, Nullable`1 configFile)

I really hate this cheese moving. (not you're fault just venting)

@TheAngryByrd
Copy link
Collaborator

Ok fixed CI I think : #141

@TheAngryByrd
Copy link
Collaborator

Could you give this a rebase?

Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also would you mind updating TaskOptionCE and JobOptionCE?

@cmeeren
Copy link
Contributor Author

cmeeren commented Oct 19, 2021

I edited this directly on GitHub. Would it be possible for you to just do a rebase while merging? Should be an arrow by the merge button. (If not, you can enable it in the repo settings.)

I'll see about TaskOption and JobOption.

@cmeeren cmeeren changed the title Canonicalize AsyncOptionBuilder type annotations Canonicalize option type annotations Oct 19, 2021
@cmeeren
Copy link
Contributor Author

cmeeren commented Oct 19, 2021

Done and done (rebased, too).

Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@TheAngryByrd TheAngryByrd merged commit d1f35fb into demystifyfp:master Oct 19, 2021
TheAngryByrd added a commit that referenced this pull request Oct 19, 2021
- [Canonicalize option type annotations](#140) Credits [@cmeeren](https://github.com/cmeeren)
TheAngryByrd added a commit that referenced this pull request Oct 19, 2021
- [Canonicalize option type annotations](#140) Credits [@cmeeren](https://github.com/cmeeren)
njlr pushed a commit to njlr/FsToolkit.ErrorHandling that referenced this pull request Nov 23, 2021
- [Canonicalize option type annotations](demystifyfp#140) Credits [@cmeeren](https://github.com/cmeeren)
njlr pushed a commit to njlr/FsToolkit.ErrorHandling that referenced this pull request Nov 23, 2021
- [Canonicalize option type annotations](demystifyfp#140) Credits [@cmeeren](https://github.com/cmeeren)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants